r74074 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74073‎ | r74074 | r74075 >
Date:16:02, 1 October 2010
Author:demon
Status:ok
Tags:
Comment:
Use getAuthorCount() instead of counting authors (followup r69933, r70827)
Modified paths:
  • /trunk/extensions/CodeReview/ui/CodeAuthorListView.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CodeReview/ui/CodeAuthorListView.php
@@ -12,7 +12,7 @@
1313 $authors = $this->mRepo->getAuthorList();
1414 $repo = $this->mRepo->getName();
1515 $text = wfMsg( 'code-authors-text' ) . "\n\n";
16 - $text .= '<strong>' . wfMsg( 'code-author-total', $wgLang->formatNum( count( $authors ) ) ) . "</strong>\n";
 16+ $text .= '<strong>' . wfMsg( 'code-author-total', $wgLang->formatNum( $this->mRepo->getAuthorCount() ) ) . "</strong>\n";
1717 foreach ( $authors as $committer ) {
1818 if ( $committer ) {
1919 $text .= "* [[Special:Code/$repo/author/$committer|$committer]]";

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69933Display Total number of authors on Special:Code/repo/authorreedy08:12, 26 July 2010
r70827Add a caching getAuthorCount, not used, as client side array counting will be...reedy15:44, 10 August 2010

Status & tagging log