r74063 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74062‎ | r74063 | r74064 >
Date:11:21, 1 October 2010
Author:reedy
Status:ok
Tags:
Comment:
Few explicit class variable definitions
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryLogEvents.php (modified) (history)
  • /trunk/phase3/includes/api/ApiQueryUserInfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryLogEvents.php
@@ -40,6 +40,11 @@
4141 parent::__construct( $query, $moduleName, 'le' );
4242 }
4343
 44+ private $fld_ids = false, $fld_title = false, $fld_type = false,
 45+ $fld_action = false, $fld_user = false, $fld_userid = false,
 46+ $fld_timestamp = false, $fld_comment = false, $fld_parsedcomment = false,
 47+ $fld_details = false, $fld_tags = false;
 48+
4449 public function execute() {
4550 $params = $this->extractRequestParams();
4651 $db = $this->getDB();
Index: trunk/phase3/includes/api/ApiQueryUserInfo.php
@@ -36,6 +36,8 @@
3737 */
3838 class ApiQueryUserInfo extends ApiQueryBase {
3939
 40+ private $prop = array();
 41+
4042 public function __construct( $query, $moduleName ) {
4143 parent::__construct( $query, $moduleName, 'ui' );
4244 }
@@ -46,8 +48,6 @@
4749
4850 if ( !is_null( $params['prop'] ) ) {
4951 $this->prop = array_flip( $params['prop'] );
50 - } else {
51 - $this->prop = array();
5252 }
5353
5454 $r = $this->getCurrentUserInfo();

Status & tagging log