r74030 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74029‎ | r74030 | r74031 >
Date:18:17, 30 September 2010
Author:neilk
Status:deferred
Tags:
Comment:
merging changes from 74019-74029 in trunk
Modified paths:
  • /branches/uploadwizard/extensions (modified) (history)
  • /branches/uploadwizard/extensions/ContactPageFundraiser (modified) (history)
  • /branches/uploadwizard/extensions/LocalisationUpdate (modified) (history)
  • /branches/uploadwizard/phase3 (modified) (history)
  • /branches/uploadwizard/phase3/COPYING (modified) (history)
  • /branches/uploadwizard/phase3/CREDITS (modified) (history)
  • /branches/uploadwizard/phase3/FAQ (modified) (history)
  • /branches/uploadwizard/phase3/HISTORY (modified) (history)
  • /branches/uploadwizard/phase3/INSTALL (modified) (history)
  • /branches/uploadwizard/phase3/README (modified) (history)
  • /branches/uploadwizard/phase3/RELEASE-NOTES (modified) (history)
  • /branches/uploadwizard/phase3/StartProfiler.sample (modified) (history)
  • /branches/uploadwizard/phase3/UPGRADE (modified) (history)
  • /branches/uploadwizard/phase3/api.php (modified) (history)
  • /branches/uploadwizard/phase3/api.php5 (modified) (history)
  • /branches/uploadwizard/phase3/bin (modified) (history)
  • /branches/uploadwizard/phase3/cache (modified) (history)
  • /branches/uploadwizard/phase3/config (modified) (history)
  • /branches/uploadwizard/phase3/docs (modified) (history)
  • /branches/uploadwizard/phase3/images (modified) (history)
  • /branches/uploadwizard/phase3/img_auth.php (modified) (history)
  • /branches/uploadwizard/phase3/img_auth.php5 (modified) (history)
  • /branches/uploadwizard/phase3/includes (modified) (history)
  • /branches/uploadwizard/phase3/includes/ChangesList.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/ConfEditor.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/GlobalFunctions.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/HistoryPage.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/Interwiki.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/OutputPage.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/ResourceLoader.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/Title.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/api (modified) (history)
  • /branches/uploadwizard/phase3/includes/installer/DatabaseInstaller.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/json/Services_JSON.php (modified) (history)
  • /branches/uploadwizard/phase3/includes/specials (modified) (history)
  • /branches/uploadwizard/phase3/index.php (modified) (history)
  • /branches/uploadwizard/phase3/index.php5 (modified) (history)
  • /branches/uploadwizard/phase3/languages (modified) (history)
  • /branches/uploadwizard/phase3/load.php (modified) (history)
  • /branches/uploadwizard/phase3/load.php5 (modified) (history)
  • /branches/uploadwizard/phase3/maintenance (modified) (history)
  • /branches/uploadwizard/phase3/maintenance/archives (modified) (history)
  • /branches/uploadwizard/phase3/maintenance/cleanupTable.inc (modified) (history)
  • /branches/uploadwizard/phase3/maintenance/deleteSelfExternals.php (modified) (history)
  • /branches/uploadwizard/phase3/maintenance/populateRevisionLength.php (modified) (history)
  • /branches/uploadwizard/phase3/maintenance/tables.sql (modified) (history)
  • /branches/uploadwizard/phase3/maintenance/tests (modified) (history)
  • /branches/uploadwizard/phase3/math (modified) (history)
  • /branches/uploadwizard/phase3/opensearch_desc.php (modified) (history)
  • /branches/uploadwizard/phase3/opensearch_desc.php5 (modified) (history)
  • /branches/uploadwizard/phase3/php5.php5 (modified) (history)
  • /branches/uploadwizard/phase3/profileinfo.php (modified) (history)
  • /branches/uploadwizard/phase3/redirect.php (modified) (history)
  • /branches/uploadwizard/phase3/redirect.php5 (modified) (history)
  • /branches/uploadwizard/phase3/redirect.phtml (modified) (history)
  • /branches/uploadwizard/phase3/resources (modified) (history)
  • /branches/uploadwizard/phase3/serialized (modified) (history)
  • /branches/uploadwizard/phase3/skins (modified) (history)
  • /branches/uploadwizard/phase3/thumb.php (modified) (history)
  • /branches/uploadwizard/phase3/thumb.php5 (modified) (history)
  • /branches/uploadwizard/phase3/trackback.php (modified) (history)
  • /branches/uploadwizard/phase3/trackback.php5 (modified) (history)
  • /branches/uploadwizard/phase3/wiki.phtml (modified) (history)

Diff [purge]

Property changes on: branches/uploadwizard/phase3/bin
___________________________________________________________________
Modified: svn:mergeinfo
11 Merged /trunk/phase3/bin:r74020-74029
Property changes on: branches/uploadwizard/phase3/COPYING
___________________________________________________________________
Modified: svn:mergeinfo
22 Merged /trunk/phase3/COPYING:r74020-74029
Property changes on: branches/uploadwizard/phase3/img_auth.php5
___________________________________________________________________
Modified: svn:mergeinfo
33 Merged /trunk/phase3/img_auth.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/trackback.php
___________________________________________________________________
Modified: svn:mergeinfo
44 Merged /trunk/phase3/trackback.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/opensearch_desc.php
___________________________________________________________________
Modified: svn:mergeinfo
55 Merged /trunk/phase3/opensearch_desc.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/redirect.php5
___________________________________________________________________
Modified: svn:mergeinfo
66 Merged /trunk/phase3/redirect.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/StartProfiler.sample
___________________________________________________________________
Modified: svn:mergeinfo
77 Merged /trunk/phase3/StartProfiler.sample:r74020-74029
Property changes on: branches/uploadwizard/phase3/docs
___________________________________________________________________
Modified: svn:mergeinfo
88 Merged /trunk/phase3/docs:r74020-74029
Property changes on: branches/uploadwizard/phase3/math
___________________________________________________________________
Modified: svn:mergeinfo
99 Merged /trunk/phase3/math:r74020-74029
Property changes on: branches/uploadwizard/phase3/load.php5
___________________________________________________________________
Modified: svn:mergeinfo
1010 Merged /trunk/phase3/load.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/index.php
___________________________________________________________________
Modified: svn:mergeinfo
1111 Merged /trunk/phase3/index.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/api.php
___________________________________________________________________
Modified: svn:mergeinfo
1212 Merged /trunk/phase3/api.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/trackback.php5
___________________________________________________________________
Modified: svn:mergeinfo
1313 Merged /trunk/phase3/trackback.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/opensearch_desc.php5
___________________________________________________________________
Modified: svn:mergeinfo
1414 Merged /trunk/phase3/opensearch_desc.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/profileinfo.php
___________________________________________________________________
Modified: svn:mergeinfo
1515 Merged /trunk/phase3/profileinfo.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/images
___________________________________________________________________
Modified: svn:mergeinfo
1616 Merged /trunk/phase3/images:r74020-74029
Property changes on: branches/uploadwizard/phase3/thumb.php
___________________________________________________________________
Modified: svn:mergeinfo
1717 Merged /trunk/phase3/thumb.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/ResourceLoader.php
___________________________________________________________________
Modified: svn:mergeinfo
1818 Merged /trunk/phase3/includes/ResourceLoader.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/json/Services_JSON.php
___________________________________________________________________
Modified: svn:mergeinfo
1919 Merged /trunk/phase3/includes/json/Services_JSON.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/ConfEditor.php
___________________________________________________________________
Modified: svn:mergeinfo
2020 Merged /trunk/phase3/includes/ConfEditor.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/installer/DatabaseInstaller.php
___________________________________________________________________
Modified: svn:mergeinfo
2121 Merged /trunk/phase3/includes/installer/DatabaseInstaller.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/Title.php
___________________________________________________________________
Modified: svn:mergeinfo
2222 Merged /trunk/phase3/includes/Title.php:r74020-74029
Index: branches/uploadwizard/phase3/includes/GlobalFunctions.php
@@ -2449,19 +2449,21 @@
24502450 $disabled = false;
24512451 if( wfIniGetBool( 'safe_mode' ) ) {
24522452 wfDebug( "wfShellExec can't run in safe_mode, PHP's exec functions are too broken.\n" );
2453 - $disabled = true;
 2453+ $disabled = 'safemode';
24542454 }
24552455 $functions = explode( ',', ini_get( 'disable_functions' ) );
24562456 $functions = array_map( 'trim', $functions );
24572457 $functions = array_map( 'strtolower', $functions );
24582458 if ( in_array( 'passthru', $functions ) ) {
24592459 wfDebug( "passthru is in disabled_functions\n" );
2460 - $disabled = true;
 2460+ $disabled = 'passthru';
24612461 }
24622462 }
24632463 if ( $disabled ) {
24642464 $retval = 1;
2465 - return 'Unable to run external programs in safe mode.';
 2465+ return $disabled == 'safemode' ?
 2466+ 'Unable to run external programs in safe mode.' :
 2467+ 'Unable to run external programs, passthru() is disabled.';
24662468 }
24672469
24682470 wfInitShellLocale();
Property changes on: branches/uploadwizard/phase3/includes/GlobalFunctions.php
___________________________________________________________________
Modified: svn:mergeinfo
24692471 Merged /trunk/phase3/includes/GlobalFunctions.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/HistoryPage.php
___________________________________________________________________
Modified: svn:mergeinfo
24702472 Merged /trunk/phase3/includes/HistoryPage.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/specials
___________________________________________________________________
Modified: svn:mergeinfo
24712473 Merged /trunk/phase3/includes/specials:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/api
___________________________________________________________________
Modified: svn:mergeinfo
24722474 Merged /trunk/phase3/includes/api:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/ChangesList.php
___________________________________________________________________
Modified: svn:mergeinfo
24732475 Merged /trunk/phase3/includes/ChangesList.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/Interwiki.php
___________________________________________________________________
Modified: svn:mergeinfo
24742476 Merged /trunk/phase3/includes/Interwiki.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes/OutputPage.php
___________________________________________________________________
Modified: svn:mergeinfo
24752477 Merged /trunk/phase3/includes/OutputPage.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/includes
___________________________________________________________________
Modified: svn:mergeinfo
24762478 Merged /trunk/phase3/includes:r74020-74029
Property changes on: branches/uploadwizard/phase3/languages
___________________________________________________________________
Modified: svn:mergeinfo
24772479 Merged /trunk/phase3/languages:r74020-74029
Index: branches/uploadwizard/phase3/RELEASE-NOTES
@@ -341,6 +341,7 @@
342342 * (bug 25292) SkinSubPageSubtitle hook now passes the Skin object as second
343343 parameter
344344 * (bug 25167) Correctly load JS fixes for IE6 (fixing a regression in 1.16)
 345+* (bug 25367) wfShellExec() is more explicit when failing due to disabled passthru()
345346
346347 === API changes in 1.17 ===
347348 * (bug 22738) Allow filtering by action type on query=logevent.
Property changes on: branches/uploadwizard/phase3/RELEASE-NOTES
___________________________________________________________________
Modified: svn:mergeinfo
348349 Merged /trunk/phase3/RELEASE-NOTES:r74020-74029
Property changes on: branches/uploadwizard/phase3/FAQ
___________________________________________________________________
Modified: svn:mergeinfo
349350 Merged /trunk/phase3/FAQ:r74020-74029
Property changes on: branches/uploadwizard/phase3/resources
___________________________________________________________________
Modified: svn:mergeinfo
350351 Merged /trunk/phase3/resources:r74020-74029
Property changes on: branches/uploadwizard/phase3/index.php5
___________________________________________________________________
Modified: svn:mergeinfo
351352 Merged /trunk/phase3/index.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/maintenance/cleanupTable.inc
___________________________________________________________________
Modified: svn:mergeinfo
352353 Merged /trunk/phase3/maintenance/cleanupTable.inc:r74020-74029
Property changes on: branches/uploadwizard/phase3/maintenance/deleteSelfExternals.php
___________________________________________________________________
Modified: svn:mergeinfo
353354 Merged /trunk/phase3/maintenance/deleteSelfExternals.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/maintenance/populateRevisionLength.php
___________________________________________________________________
Modified: svn:mergeinfo
354355 Merged /trunk/phase3/maintenance/populateRevisionLength.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/maintenance/archives
___________________________________________________________________
Modified: svn:mergeinfo
355356 Merged /trunk/phase3/maintenance/archives:r74020-74029
Property changes on: branches/uploadwizard/phase3/maintenance/tables.sql
___________________________________________________________________
Modified: svn:mergeinfo
356357 Merged /trunk/phase3/maintenance/tables.sql:r74020-74029
Property changes on: branches/uploadwizard/phase3/maintenance/tests
___________________________________________________________________
Modified: svn:mergeinfo
357358 Merged /trunk/phase3/maintenance/tests:r74020-74029
Property changes on: branches/uploadwizard/phase3/maintenance
___________________________________________________________________
Modified: svn:mergeinfo
358359 Merged /trunk/phase3/maintenance:r74020-74029
Property changes on: branches/uploadwizard/phase3/img_auth.php
___________________________________________________________________
Modified: svn:mergeinfo
359360 Merged /trunk/phase3/img_auth.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/api.php5
___________________________________________________________________
Modified: svn:mergeinfo
360361 Merged /trunk/phase3/api.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/redirect.phtml
___________________________________________________________________
Modified: svn:mergeinfo
361362 Merged /trunk/phase3/redirect.phtml:r74020-74029
Property changes on: branches/uploadwizard/phase3/wiki.phtml
___________________________________________________________________
Modified: svn:mergeinfo
362363 Merged /trunk/phase3/wiki.phtml:r74020-74029
Property changes on: branches/uploadwizard/phase3/php5.php5
___________________________________________________________________
Modified: svn:mergeinfo
363364 Merged /trunk/phase3/php5.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/UPGRADE
___________________________________________________________________
Modified: svn:mergeinfo
364365 Merged /trunk/phase3/UPGRADE:r74020-74029
Property changes on: branches/uploadwizard/phase3/skins
___________________________________________________________________
Modified: svn:mergeinfo
365366 Merged /trunk/phase3/skins:r74020-74029
Property changes on: branches/uploadwizard/phase3/redirect.php
___________________________________________________________________
Modified: svn:mergeinfo
366367 Merged /trunk/phase3/redirect.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/thumb.php5
___________________________________________________________________
Modified: svn:mergeinfo
367368 Merged /trunk/phase3/thumb.php5:r74020-74029
Property changes on: branches/uploadwizard/phase3/serialized
___________________________________________________________________
Modified: svn:mergeinfo
368369 Merged /trunk/phase3/serialized:r74020-74029
Property changes on: branches/uploadwizard/phase3/CREDITS
___________________________________________________________________
Modified: svn:mergeinfo
369370 Merged /trunk/phase3/CREDITS:r74020-74029
Property changes on: branches/uploadwizard/phase3/README
___________________________________________________________________
Modified: svn:mergeinfo
370371 Merged /trunk/phase3/README:r74020-74029
Property changes on: branches/uploadwizard/phase3/HISTORY
___________________________________________________________________
Modified: svn:mergeinfo
371372 Merged /trunk/phase3/HISTORY:r74020-74029
Property changes on: branches/uploadwizard/phase3/cache
___________________________________________________________________
Modified: svn:mergeinfo
372373 Merged /trunk/phase3/cache:r74020-74029
Property changes on: branches/uploadwizard/phase3/load.php
___________________________________________________________________
Modified: svn:mergeinfo
373374 Merged /trunk/phase3/load.php:r74020-74029
Property changes on: branches/uploadwizard/phase3/config
___________________________________________________________________
Modified: svn:mergeinfo
374375 Merged /trunk/phase3/config:r74020-74029
Property changes on: branches/uploadwizard/phase3/INSTALL
___________________________________________________________________
Modified: svn:mergeinfo
375376 Merged /trunk/phase3/INSTALL:r74020-74029
Property changes on: branches/uploadwizard/phase3
___________________________________________________________________
Modified: svn:mergeinfo
376377 Merged /trunk/phase3:r74020-74029*
Property changes on: branches/uploadwizard/extensions/ContactPageFundraiser
___________________________________________________________________
Modified: svn:mergeinfo
377378 Merged /trunk/phase3/extensions/ContactPageFundraiser:r74020-74029
Property changes on: branches/uploadwizard/extensions/LocalisationUpdate
___________________________________________________________________
Modified: svn:mergeinfo
378379 Merged /trunk/phase3/extensions/LocalisationUpdate:r74020-74029
Property changes on: branches/uploadwizard/extensions
___________________________________________________________________
Modified: svn:mergeinfo
379380 Merged /trunk/phase3/extensions:r74020-74029

Status & tagging log