r74001 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r74000‎ | r74001 | r74002 >
Date:23:04, 29 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Removed code for compatibility with MW 1.13
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/specials/AskSpecial/SMW_SpecialAsk.php
@@ -19,9 +19,6 @@
2020 protected $m_printouts = array();
2121 protected $m_editquery = false;
2222
23 - // MW 1.13 compatibilty
24 - protected static $pipeseparator = '|';
25 -
2623 /**
2724 * Constructor
2825 */
@@ -41,10 +38,6 @@
4239 $this->setHeaders();
4340 wfProfileIn( 'doSpecialAsk (SMW)' );
4441
45 - if ( $smwgMW_1_14 ) { // since MW 1.14.0 this is governed by a message
46 - SMWAskPage::$pipeseparator = wfMsgExt( 'pipe-separator' , 'escapenoentities' );
47 - }
48 -
4942 if ( !$smwgQEnabled ) {
5043 $wgOut->addHTML( '<br />' . wfMsg( 'smw_iq_disabled' ) );
5144 } else {
@@ -588,19 +581,17 @@
589582 $result .= '<br /><input type="submit" value="' . wfMsg( 'smw_ask_submit' ) . '"/>' .
590583 '<input type="hidden" name="eq" value="yes"/>' .
591584 ' <a href="' . htmlspecialchars( $skin->makeSpecialUrl( 'Ask', $urltail ) ) . '" rel="nofollow">' . wfMsg( 'smw_ask_hidequery' ) . '</a> ' .
592 - SMWAskPage::$pipeseparator . ' ' . SMWAskPage::getEmbedToggle() .
593 - SMWAskPage::$pipeseparator .
594 - ' <a href="' . htmlspecialchars( wfMsg( 'smw_ask_doculink' ) ) . '">' . wfMsg( 'smw_ask_help' ) . '</a>' .
 585+ '| ' . SMWAskPage::getEmbedToggle() .
 586+ '| <a href="' . htmlspecialchars( wfMsg( 'smw_ask_doculink' ) ) . '">' . wfMsg( 'smw_ask_help' ) . '</a>' .
595587 "\n</form>";
596588 } else { // if $this->m_editquery == false
597589 $urltail = str_replace( '&eq=no', '', $urltail ) . '&eq=yes';
598590 $result .= '<p><a href="' . htmlspecialchars( $skin->makeSpecialUrl( 'Ask', $urltail ) ) . '" rel="nofollow">' . wfMsg( 'smw_ask_editquery' ) . '</a> ' .
599 - SMWAskPage::$pipeseparator . ' ' . SMWAskPage::getEmbedToggle() . '</p>';
 591+ '| ' . SMWAskPage::getEmbedToggle() . '</p>';
600592 '<input type="hidden" name="eq" value="yes"/>' .
601593 ' <a href="' . htmlspecialchars( $skin->makeSpecialUrl( 'Ask', $urltail ) ) . '" rel="nofollow">' . wfMsg( 'smw_ask_hidequery' ) . '</a> ' .
602 - SMWAskPage::$pipeseparator . ' ' . SMWAskPage::getEmbedToggle() .
603 - SMWAskPage::$pipeseparator .
604 - ' <a href="' . htmlspecialchars( wfMsg( 'smw_ask_doculink' ) ) . '">' . wfMsg( 'smw_ask_help' ) . '</a>' .
 594+ '| ' . SMWAskPage::getEmbedToggle() .
 595+ '| <a href="' . htmlspecialchars( wfMsg( 'smw_ask_doculink' ) ) . '">' . wfMsg( 'smw_ask_help' ) . '</a>' .
605596 "\n</form>";
606597 }
607598
@@ -678,7 +669,7 @@
679670 $navigation .= '&#160;&#160;&#160;&#160;&#160;&#160;&#160;&#160;(';
680671 $first = false;
681672 } else {
682 - $navigation .= ' ' . SMWAskPage::$pipeseparator . ' ';
 673+ $navigation .= ' | ';
683674 }
684675
685676 if ( $limit != $l ) {

Status & tagging log