r73960 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73959‎ | r73960 | r73961 >
Date:17:25, 29 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
fixing per comments at r70517
Modified paths:
  • /trunk/phase3/includes/parser/CoreParserFunctions.php (modified) (history)
  • /trunk/phase3/includes/parser/ParserOptions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/parser/CoreParserFunctions.php
@@ -86,7 +86,7 @@
8787 static function intFunction( $parser, $part1 = '' /*, ... */ ) {
8888 if ( strval( $part1 ) !== '' ) {
8989 $args = array_slice( func_get_args(), 2 );
90 - $message = wfMsgGetKey( $part1, true, $parser->mOptions->getUserLang(), false );
 90+ $message = wfMsgGetKey( $part1, true, $parser->getOptions()->getUserLang(), false );
9191 $message = wfMsgReplaceArgs( $message, $args );
9292 $message = $parser->replaceVariables( $message ); // like $wgMessageCache->transform()
9393 return $message;
Index: trunk/phase3/includes/parser/ParserOptions.php
@@ -103,9 +103,11 @@
104104 return $this->mTimestamp;
105105 }
106106
107 - # You shouldn't use this. Really. $parser->getFunctionLang() is all you need.
108 - # Using this fragments the cache and is discouraged. Yes, {{int: }} uses this,
109 - # producing inconsistent tables (Bug 14404).
 107+ /**
 108+ * You shouldn't use this. Really. $parser->getFunctionLang() is all you need.
 109+ * Using this fragments the cache and is discouraged. Yes, {{int: }} uses this,
 110+ * producing inconsistent tables (Bug 14404).
 111+ */
110112 function getUserLang() {
111113 $this->accessedOptions['userlang'] = true;
112114 return $this->mUserLang;

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70517Make intfunction go accross the ParserOptions....platonides18:43, 5 August 2010

Status & tagging log