r73919 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73918‎ | r73919 | r73920 >
Date:17:17, 28 September 2010
Author:siebrand
Status:deferred
Tags:
Comment:
$langs could be incorrect as it was fed back into TranslationStats::getPercentageTranslated()
Modified paths:
  • /trunk/extensions/Translate/scripts/export.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/scripts/export.php
@@ -71,7 +71,7 @@
7272 $threshold = false;
7373 }
7474
75 -$langs = Cli::parseLanguageCodes( $options['lang'] );
 75+$reqLangs = Cli::parseLanguageCodes( $options['lang'] );
7676
7777 $groups = array();
7878
@@ -108,10 +108,12 @@
109109 if ( $threshold ) {
110110 $langs = TranslationStats::getPercentageTranslated(
111111 $groupId,
112 - $langs,
 112+ $reqLangs,
113113 $threshold,
114114 true
115115 );
 116+ } else {
 117+ $langs = $reqLangs;
116118 }
117119
118120 if ( $group instanceof FileBasedMessageGroup ) {

Status & tagging log