r73915 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73914‎ | r73915 | r73916 >
Date:15:58, 28 September 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Revert r73879 for now, not ready yet.
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/language/messages.inc
@@ -369,8 +369,8 @@
370370 'perfcachedts',
371371 'querypage-no-updates',
372372 'wrong_wfQuery_params',
373 - 'viewsourcetitle',
374 - 'viewsourceheader',
 373+ 'viewsource',
 374+ 'viewsourcefor',
375375 'actionthrottled',
376376 'actionthrottledtext',
377377 'protectedpagetext',
Index: trunk/phase3/includes/OutputPage.php
@@ -1992,10 +1992,10 @@
19931993 if ( !empty( $reasons ) ) {
19941994 // Permissions error
19951995 if( $source ) {
1996 - $title = $this->getTitle();
1997 - $link = $skin->linkKnown( $title );
1998 - $this->mPagetitle = wfMessage( 'viewsourceheader' )->rawParams( $link )->escaped();
1999 - $this->mHTMLtitle = wfMessage( 'viewsourcetitle', $title->getPrefixedText() )->escaped();
 1996+ $this->setPageTitle( wfMsg( 'viewsource' ) );
 1997+ $this->setSubtitle(
 1998+ wfMsg( 'viewsourcefor', $skin->linkKnown( $this->getTitle() ) )
 1999+ );
20002000 } else {
20012001 $this->setPageTitle( wfMsg( 'badaccess' ) );
20022002 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1002,8 +1002,8 @@
10031003 'wrong_wfQuery_params' => 'Incorrect parameters to wfQuery()<br />
10041004 Function: $1<br />
10051005 Query: $2',
1006 -'viewsourcetitle' => 'Source for page $1',
1007 -'viewsourceheader' => 'Source for page $1',
 1006+'viewsource' => 'View source',
 1007+'viewsourcefor' => 'for $1',
10081008 'actionthrottled' => 'Action throttled',
10091009 'actionthrottledtext' => 'As an anti-spam measure, you are limited from performing this action too many times in a short space of time, and you have exceeded this limit.
10101010 Please try again in a few minutes.',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73879Replace imho ugly viewsourcefor subtitle with viewsourcetitle and viewsourceh...nikerabbit10:04, 28 September 2010

Status & tagging log