r73783 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73782‎ | r73783 | r73784 >
Date:16:37, 26 September 2010
Author:ialex
Status:ok
Tags:
Comment:
* (bug 25292) SkinSubPageSubtitle hook now passes the Skin object as second parameter
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/Skin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1444,8 +1444,8 @@
14451445 &$forContent: overridable flag if copyright footer is shown in content language.
14461446
14471447 'SkinSubPageSubtitle': At the beginning of Skin::subPageSubtitle()
 1448+&$subpages: Subpage links HTML
14481449 $skin: Skin object
1449 -&$subpages: Subpage links HTML
14501450 If false is returned $subpages will be used instead of the HTML
14511451 subPageSubtitle() generates.
14521452 If true is returned, $subpages will be ignored and the rest of
Index: trunk/phase3/includes/Skin.php
@@ -1058,7 +1058,7 @@
10591059 function subPageSubtitle() {
10601060 $subpages = '';
10611061
1062 - if ( !wfRunHooks( 'SkinSubPageSubtitle', array( &$subpages ) ) ) {
 1062+ if ( !wfRunHooks( 'SkinSubPageSubtitle', array( &$subpages, $this ) ) ) {
10631063 return $subpages;
10641064 }
10651065
Index: trunk/phase3/RELEASE-NOTES
@@ -337,6 +337,8 @@
338338 * (bug 24987) Special:ListUsers does not take external groups into account
339339 * (bug 20633) update.php has mixed language output
340340 * SQLite system table names are now never prefixed.
 341+* (bug 25292) SkinSubPageSubtitle hook now passes the Skin object as second
 342+ parameter
341343
342344 === API changes in 1.17 ===
343345 * (bug 22738) Allow filtering by action type on query=logevent.

Status & tagging log