r73781 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73780‎ | r73781 | r73782 >
Date:15:59, 26 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
CHanges for 0.4 - some small fixed
Modified paths:
  • /trunk/extensions/Validator/includes/ParserHook.php (modified) (history)
  • /trunk/extensions/Validator/includes/criteria/CriterionItemCount.php (modified) (history)
  • /trunk/extensions/Validator/includes/criteria/CriterionUniqueItems.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Validator/includes/criteria/CriterionItemCount.php
@@ -34,7 +34,7 @@
3535 /**
3636 * @see ParameterCriterion::validate
3737 */
38 - public function validate( ListParameter $parameter ) {
 38+ public function validate( Parameter $parameter ) {
3939 $count = count( $parameter->value );
4040 return $count <= $this->upperBound && $count >= $this->lowerBound;
4141 }
Index: trunk/extensions/Validator/includes/criteria/CriterionUniqueItems.php
@@ -25,7 +25,7 @@
2626 /**
2727 * @see ParameterCriterion::validate
2828 */
29 - public function validate( ListParameter $parameter ) {
 29+ public function validate( Parameter $parameter ) {
3030 return count( $parameter->value ) == count( array_unique( $parameter->value ) );
3131 }
3232
Index: trunk/extensions/Validator/includes/ParserHook.php
@@ -97,11 +97,11 @@
9898 * @param minxed $input string or null
9999 * @param array $args
100100 * @param Parser $parser
101 - * @param PPFrame $frame
 101+ * @param PPFrame $frame Available from 1.16 - commented for bc for now
102102 *
103103 * @return string
104104 */
105 - public function renderTag( $input, array $args, Parser $parser, PPFrame $frame ) {
 105+ public function renderTag( $input, array $args, Parser $parser /*, PPFrame $frame*/ ) {
106106 $this->parser = $parser;
107107
108108 $defaultParam = array_shift( $this->getDefaultParameters() );

Status & tagging log