r73769 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73768‎ | r73769 | r73770 >
Date:05:04, 26 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Fixed some fails from r73767
Modified paths:
  • /trunk/extensions/Maps/includes/services/GoogleMaps/Maps_GoogleMaps.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayers.php (modified) (history)
  • /trunk/extensions/Maps/includes/services/YahooMaps/Maps_YahooMaps.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/services/YahooMaps/Maps_YahooMaps.php
@@ -68,7 +68,7 @@
6969 array(
7070 new CriterionInArray( self::getTypeNames() ),
7171 ),
72 - array( 'types' )
 72+ array( 'types' )
7373 );
7474 $params['type']->addManipulations( new MapsParamYMapType() );
7575
@@ -82,7 +82,7 @@
8383 new CriterionInArray( self::getTypeNames() ),
8484 )
8585 );
86 - $params['type']->addManipulations( new MapsParamYMapType() );
 86+ $params['types']->addManipulations( new MapsParamYMapType(), new ParamManipulationImplode( ',', "'" ) );
8787
8888 $params['autozoom'] = new Parameter(
8989 'autozoom',
Index: trunk/extensions/Maps/includes/services/OpenLayers/Maps_OpenLayers.php
@@ -65,7 +65,7 @@
6666 $egMapsOLLayers,
6767 array(),
6868 array(
69 - new CriterionInArray( self::getLayerNames( true ) ),
 69+ new CriterionInArray( self::getLayerNames( true ), new ParamManipulationImplode( ',', "'" ) ),
7070 )
7171 );
7272
Index: trunk/extensions/Maps/includes/services/GoogleMaps/Maps_GoogleMaps.php
@@ -82,7 +82,7 @@
8383 new CriterionInArray( array_keys( self::$mapTypes ) ),
8484 )
8585 );
86 - $params['types']->addManipulations( new MapsParamGMapType() );
 86+ $params['types']->addManipulations( new MapsParamGMapType(), new ParamManipulationImplode( ',', "'" ) );
8787
8888 $params['autozoom'] = new Parameter(
8989 'autozoom',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73767Changes for 0.7 - Follow up to r73766jeroendedauw04:51, 26 September 2010

Status & tagging log