r73709 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73708‎ | r73709 | r73710 >
Date:03:54, 25 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r73708
Modified paths:
  • /trunk/extensions/Maps/includes/parserHooks/Maps_Finddestination.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/includes/parserHooks/Maps_Finddestination.php
@@ -59,16 +59,8 @@
6060
6161 $params = array();
6262
63 - $params['location'] = new Parameter(
64 - 'location',
65 - Parameter::TYPE_STRING,
66 - null,
67 - array(),
68 - array(
69 - new CriterionIsLocation(),
70 - )
71 - );
72 -
 63+ $params['location'] = new Parameter( 'location' );
 64+ $params['location']->addCriteria( new CriterionIsLocation() );
7365 $params['location']->lowerCaseValue = false;
7466
7567 $params['bearing'] = new Parameter(
@@ -76,10 +68,8 @@
7769 Parameter::TYPE_FLOAT
7870 );
7971
80 - $params['distance'] = new Parameter(
81 - 'distance'
82 - // TODO: add distance criterion
83 - );
 72+ $params['distance'] = new Parameter( 'distance' );
 73+ $params['distance']->addCriteria( new CriterionIsDistance() );
8474
8575 $params['mappingservice'] = new Parameter(
8676 'mappingservice',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73708Addded distance criterionjeroendedauw03:47, 25 September 2010

Status & tagging log