r73684 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73683‎ | r73684 | r73685 >
Date:21:39, 24 September 2010
Author:kaldari
Status:deferred
Tags:
Comment:
changing openElement to element, changing tags to element (consistant escaping)
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumn.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumn.php
@@ -29,7 +29,7 @@
3030 $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit'));
3131 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ));
3232 //$form .= Xml::submitButton( wfMsg( 'payflowpro_gateway-submit-button' ));
33 - $form .= Xml::openElement( 'input', array( 'class' => 'input-button button-navyblue', 'value' => wfMsg( 'payflowpro_gateway-submit-button'), 'onclick' => 'submit_form( this )', 'type' => 'submit'));
 33+ $form .= Xml::element( 'input', array( 'class' => 'input-button button-navyblue', 'value' => wfMsg( 'payflowpro_gateway-submit-button'), 'onclick' => 'submit_form( this )', 'type' => 'submit'));
3434 $form .= Xml::closeElement( 'div' );
3535 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
3636 wfMsg( 'payflowpro_gateway-donate-click' );
@@ -193,7 +193,7 @@
194194 // card logos
195195 $form .= '<tr>';
196196 $form .= '<td />';
197 - $form .= '<td>' . Xml::tags( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" )) . '</td>';
 197+ $form .= '<td>' . Xml::element( 'img', array( 'src' => $wgScriptPath . "/extensions/DonationInterface/payflowpro_gateway/includes/credit_card_logos.gif" )) . '</td>';
198198 $form .= '</tr>';
199199
200200 // credit card type

Status & tagging log