r73679 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73678‎ | r73679 | r73680 >
Date:20:59, 24 September 2010
Author:neilk
Status:deferred
Tags:
Comment:
use FormatJson rather than making a new Services_JSON
Modified paths:
  • /branches/uploadwizard/extensions/UploadWizard/UploadWizardMessages.php (modified) (history)

Diff [purge]

Index: branches/uploadwizard/extensions/UploadWizard/UploadWizardMessages.php
@@ -49,8 +49,7 @@
5050 $messagesForJs[ $key ] = wfMsgGetKey( $key, /*DB*/true, $language, /*Transform*/false );
5151 }
5252
53 - $json = new Services_JSON();
54 - $messagesJson = $json->encode( $messagesForJs );
 53+ $messagesJson = FormatJson::encode( $messagesForJs );
5554 return 'mw.addMessages(' . $messagesJson . ');';
5655 }
5756
@@ -69,5 +68,3 @@
7069 }
7170
7271 }
73 -
74 -?>

Status & tagging log