r73659 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73658‎ | r73659 | r73660 >
Date:14:40, 24 September 2010
Author:gurch
Status:ok
Tags:
Comment:
reimplement r73652 having actually read coding conventions this time
Modified paths:
  • /trunk/phase3/includes/api/ApiQuerySiteinfo.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQuerySiteinfo.php
@@ -335,11 +335,11 @@
336336 if ( $numberInGroup ) {
337337 global $wgAutopromote;
338338
339 - if ($group == 'user') {
 339+ if ( $group == 'user' ) {
340340 $arr['number'] = SiteStats::users();
341341
342342 // '*' and autopromote groups have no size
343 - } elseif (!($group == '*' || in_array($group, array_keys($wgAutopromote)))) {
 343+ } elseif ( $group !== '*' && !isset( $wgAutopromote[$group] ) ) {
344344 $arr['number'] = SiteStats::numberInGroup( $group );
345345 }
346346 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73652API: sinumberingroup now gives correct size of 'user' group, and omits size o...gurch13:00, 24 September 2010

Status & tagging log