r73608 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73607‎ | r73608 | r73609 >
Date:17:21, 23 September 2010
Author:dale
Status:deferred
Tags:
Comment:
fixed the localised text for timedText remote
set slider scale to more reasonable size per max resolution
Modified paths:
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.FirefoggRender.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/tools/mw.SequencerTools.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/TimedText/TimedText.i18n.php (modified) (history)
  • /branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/TimedText/remotes/RemoteMwTimedText.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/TimedText/mw.TimedText.js
@@ -950,6 +950,7 @@
951951 if( time >= caption.start &&
952952 time <= caption.end ) {
953953 this.prevIndex = i;
 954+ //mw.log("Start cap time: " + caption.start + ' End time: ' + caption.end );
954955 return caption.content;
955956 }
956957 }
Index: branches/MwEmbedStandAlone/modules/TimedText/TimedText.i18n.php
@@ -54,7 +54,7 @@
5555 'mwe-timedtext-textcat-lin' => 'Linguistic markup',
5656 'mwe-timedtext-textcat-cue' => 'Cue points',
5757 'mwe-timedtext-language-subtitles-for-clip' => '$1 subtitles for clip: $2',
58 - 'mwe-timedtext-language-no-subtitles-for-clip' => 'No $1 subtitles where found for clip: $2',
 58+ 'mwe-timedtext-language-no-subtitles-for-clip' => 'No $1 subtitles where found for clip: $2'
5959 );
6060
6161 /** Message documentation (Message documentation)
Index: branches/MwEmbedStandAlone/modules/TimedText/remotes/RemoteMwTimedText.js
@@ -4,11 +4,12 @@
55 * Does some transformations to normal wiki timed Text pages to make them look
66 * like the php output that we will eventually want to have
77 */
8 -mw.addMessages( {
9 - "mwe-language-subtitles-for-clip": "$1 subtitles for clip: $2",
10 - "mwe-language-no-subtitles-for-clip": "No $1 subtitles where found for clip: $2"
11 -});
128
 9+mw.addMessageKeys( [
 10+ "mwe-timedtext-language-subtitles-for-clip",
 11+ "mwe-timedtext-language-no-subtitles-for-clip"
 12+]);
 13+
1314 RemoteMwTimedText = function( options ) {
1415 return this.init( options );
1516 }
@@ -103,9 +104,9 @@
104105 player.timedText.setupTextSources( function() {
105106
106107 var source = player.timedText.getSourceByLanguage( _this.langKey );
107 - var pageMsgKey = 'mwe-language-subtitles-for-clip';
 108+ var pageMsgKey = 'mwe-timedtext-language-subtitles-for-clip';
108109 if( ! source ) {
109 - pageMsgKey = "mwe-language-no-subtitles-for-clip"
 110+ pageMsgKey = "mwe-timedtext-language-no-subtitles-for-clip"
110111 }
111112 // Add the page msg to the top
112113 $j( _this.target ).prepend(
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.FirefoggRender.js
@@ -177,7 +177,7 @@
178178 // Don't block on render
179179 setTimeout( function(){
180180 _this.doNextFrame();
181 - }, 0);
 181+ }, 1);
182182 }
183183 }, true /* hide the buffer overlay */ );
184184 },
Index: branches/MwEmbedStandAlone/modules/Sequencer/tools/mw.SequencerTools.js
@@ -866,7 +866,7 @@
867867 // Return the trimTimeline edit widget
868868 'draw': function( _this, target, smilElement ){
869869 var smil = _this.sequencer.getSmil();
870 - var sliderScale = 10000000
 870+ var sliderScale = 2000 // assume slider is never more than 2000 pixles wide.
871871 // check if thumbs are supported
872872 if( _this.sequencer.getSmil().getRefType( smilElement ) == 'video' ){
873873 $j(target).append(

Status & tagging log