r73596 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73595‎ | r73596 | r73597 >
Date:10:46, 23 September 2010
Author:gurch
Status:ok
Tags:
Comment:
follow up r72387: using ApiQuery here breaks ApiParamInfo (bug 25248)
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryBase.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBase.php
@@ -40,7 +40,7 @@
4141
4242 private $mQueryModule, $mDb, $tables, $where, $fields, $options, $join_conds;
4343
44 - public function __construct( ApiQuery $query, $moduleName, $paramPrefix = '' ) {
 44+ public function __construct( ApiBase $query, $moduleName, $paramPrefix = '' ) {
4545 parent::__construct( $query->getMain(), $moduleName, $paramPrefix );
4646 $this->mQueryModule = $query;
4747 $this->mDb = null;

Follow-up revisions

RevisionCommit summaryAuthorDate
r74098* (bug 25248) API: paraminfo errors with certain modules...reedy20:12, 1 October 2010
r74217MFT r74098, r74099...reedy15:53, 3 October 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72387Make happy check-vars. This shows it that getQuery() returns an ApiQuery (mor...platonides18:31, 4 September 2010

Status & tagging log