r73585 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73584‎ | r73585 | r73586 >
Date:00:11, 23 September 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Fixed javascript used during cc form submit
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumn.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/validate_input.js (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/validate_input.js
@@ -61,6 +61,12 @@
6262 return true;
6363 }
6464
 65+function submit_form( ccform ) {
 66+ if ( validate_form( ccform )) {
 67+ ccform.submit();
 68+ }
 69+ return true;
 70+}
6571
6672 function disableStates( form ) {
6773
Index: trunk/extensions/DonationInterface/payflowpro_gateway/forms/TwoColumn.php
@@ -29,7 +29,7 @@
3030 $form = Xml::openElement( 'div', array( 'id' => 'payflowpro_gateway-form-submit'));
3131 $form .= Xml::openElement( 'div', array( 'id' => 'mw-donate-submit-button' ));
3232 //$form .= Xml::submitButton( wfMsg( 'payflowpro_gateway-submit-button' ));
33 - $form .= Xml::openElement( 'input', array( 'class' => 'input-button button-navyblue', 'value' => wfMsg( 'payflowpro_gateway-submit-button'), 'onclick' => 'form.submit()', 'type' => 'submit'));
 33+ $form .= Xml::openElement( 'input', array( 'class' => 'input-button button-navyblue', 'value' => wfMsg( 'payflowpro_gateway-submit-button'), 'onclick' => 'submit_form( this )', 'type' => 'submit'));
3434 $form .= Xml::closeElement( 'div' );
3535 $form .= Xml::openElement( 'div', array( 'class' => 'mw-donate-submessage', 'id' => 'payflowpro_gateway-donate-submessage' ) ) .
3636 wfMsg( 'payflowpro_gateway-donate-click' );

Status & tagging log