r73570 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73569‎ | r73570 | r73571 >
Date:20:55, 22 September 2010
Author:dale
Status:deferred
Tags:
Comment:
* some minor fixes for overlay display and control binding css issues
* bumped mwRemoteVersion for update
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/mw.EmbedPlayer.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/kskin/mw.PlayerSkinKskin.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.FirefoggRender.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerServer.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/remotes/mw.MediaWikiRemoteSequencer.js (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/mw.EmbedPlayer.js
@@ -2981,8 +2981,8 @@
29822982 _this.volume = this.getPlayerElementVolume();
29832983
29842984 // update the mute state from the player element
2985 - if( _this.muted != _this.getPlayerElementMuted() ){
2986 - mw.log("monitor:: muted does not mach embed player" );
 2985+ if( _this.muted != _this.getPlayerElementMuted() && ! _this.isStopped() ){
 2986+ mw.log( "EmbedPlayer::monitor: muted does not mach embed player" );
29872987 _this.toggleMute();
29882988 // Make sure they match:
29892989 _this.muted = _this.getPlayerElementMuted();
Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/kskin/mw.PlayerSkinKskin.js
@@ -114,7 +114,8 @@
115115 'top' : '0px',
116116 'left' : '0px',
117117 'bottom' : '0px',
118 - 'right' : '45px'
 118+ 'right' : '45px',
 119+ 'overflow' : 'hidden'
119120 } )
120121 for ( var menuItem in ctrlObj.supportedMenuItems ) {
121122 $menuScreens.append(
Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js
@@ -605,7 +605,7 @@
606606 .animate( {
607607 'bottom' : 10
608608 }, 'slow' );
609 -
 609+
610610 },
611611
612612 /**
@@ -613,7 +613,7 @@
614614 */
615615 showControlBar: function(){
616616 var animateDuration = 'slow';
617 - $j( this.embedPlayer.getPlayerElement() ).css('z-index', '1')
 617+ $j( this.embedPlayer.getPlayerElement() ).css( 'z-index', '1' )
618618 mw.log( 'showControlBar' );
619619 // Move up text track if present
620620 this.embedPlayer.$interface.find( '.track' )
@@ -625,7 +625,7 @@
626626 );
627627
628628 // Show interface controls
629 - this.embedPlayer.$interface.find( '.control-bar')
 629+ this.embedPlayer.$interface.find( '.control-bar' )
630630 .fadeIn( animateDuration );
631631 },
632632
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.FirefoggRender.js
@@ -177,7 +177,7 @@
178178 // Don't block on render
179179 setTimeout( function(){
180180 _this.doNextFrame();
181 - }, 2 );
 181+ }, 0);
182182 }
183183 }, true /* hide the buffer overlay */ );
184184 },
Index: branches/MwEmbedStandAlone/modules/Sequencer/remotes/mw.MediaWikiRemoteSequencer.js
@@ -60,18 +60,23 @@
6161 $j( embedPlayer ).siblings( '.kalturaEditOverlay' ).fadeOut( 'fast' );
6262 });
6363
64 - $j( embedPlayer ).bind( 'pause', function() {
65 - mw.remoteSequencerAddEditOverlay( embedPlayerId )
 64+ $j( embedPlayer ).bind( 'pause', function() {
 65+ // don't display if near the end of playback ( causes double fade in conflict with ended event )
 66+ mw.remoteSequencerAddEditOverlay( embedPlayerId );
 67+
6668 // xxx should use getter setter
6769 embedPlayer.controlBuilder.displayOptionsMenuFlag = true;
6870 return true;
6971 });
7072
71 - $j( embedPlayer ).bind( 'ended', function( onDoneAction ){
 73+ $j( embedPlayer ).bind( 'ended', function( onDoneAction ){
 74+ if( embedPlayer.currentTime != 0 ){
 75+ return ;
 76+ }
7277 // pause event should fire
7378 mw.remoteSequencerAddEditOverlay( embedPlayerId );
7479
75 - // show the credits screen after 3 seconds 1/2 second to fade in
 80+ // show the credits screen after 3 seconds 1/2 seconds
7681 setTimeout(function(){
7782 $j( embedPlayer ).siblings( '.kalturaEditOverlay' ).fadeOut( 'fast' );
7883 embedPlayer.$interface.find('.k-menu').fadeIn('fast');
@@ -136,7 +141,7 @@
137142 'background' : 'none repeat scroll 0 0 #FFF',
138143 'color' : 'black',
139144 'opacity': 0.9,
140 - 'z-index': 999
 145+ 'z-index': 1
141146 })
142147 .append(
143148 $j('<div />')
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerServer.js
@@ -204,7 +204,7 @@
205205 'title' : _this.titleKey,
206206 'text' : _this.wrapSequencerWikiText( sequenceXML ),
207207 'token': token
208 - };
 208+ };
209209 mw.getJSON( _this.getApiUrl(), request, function( data ) {
210210 if( data.edit && data.edit.result == 'Success' ) {
211211 // Update the latest local variables
Index: branches/MwEmbedStandAlone/remotes/mediaWiki.js
@@ -4,7 +4,7 @@
55 */
66 var urlparts = getRemoteEmbedPath();
77 var mwEmbedHostPath = urlparts[0];
8 -var mwRemoteVersion = 'r149';
 8+var mwRemoteVersion = 'r150';
99 var mwUseScriptLoader = true;
1010
1111 // Log the mwRemote version makes it easy to debug cache issues
@@ -170,7 +170,7 @@
171171
172172 window.mwSequencerRemote = new mw.MediaWikiRemoteSequencer({
173173 'action': wgAction,
174 - 'titleKey' : wgTitle,
 174+ 'titleKey' : wgPageName,
175175 'target' : '#bodyContent'
176176 });
177177 window.mwSequencerRemote.drawUI();

Status & tagging log