r73523 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r73522
|
r73523
|
r73524
>
Date:
12:58, 22 September 2010
Author:
catrope
Status:
deferred
Tags:
Comment:
ArticleAssessment: Per
r73257
CR, use the second parameter of getVal() (default value) to eliminate a second call. Also use getCheck() instead of getVal() !== null, merge the two conditions and trigger on &oldid as well.
Modified paths:
/trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.hooks.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.hooks.php
—
—
@@ -80,10 +80,9 @@
81
81
global $wgRequest;
82
82
83
83
// Only show for view actions.
84
- if ( $wgRequest->getVal( 'action' ) !== null && $wgRequest->getVal( 'action' ) !== 'view' ) {
84
+ if ( $wgRequest->getVal( 'action', 'view' ) !== 'view' || $wgRequest->getCheck( 'diff' ) ||
85
+ $wgRequest->getCheck( 'oldid' ) ) {
85
86
return true;
86
- } else if ( $wgRequest->getVal( 'diff' ) !== null) {
87
- return true;
88
87
}
89
88
90
89
global $wgArticleAssessmentCategory;
Past revisions this follows-up on
Revision
Commit summary
Author
Date
r73257
Only show on view pages.
bharris
23:08, 17 September 2010
Status & tagging log
00:20, 14 September 2011
Meno25
(
talk
|
contribs
)
changed the
status
of r73523
[
removed:
old
added:
deferred]
22:14, 3 December 2010
Reedy
(
talk
|
contribs
)
changed the
status
of r73523
[
removed:
new
added:
old]