r73505 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73504‎ | r73505 | r73506 >
Date:01:02, 22 September 2010
Author:yaron
Status:deferred
Tags:
Comment:
Fix from Simon Bachenberg - 'display' value for displayed divs in 'show on select' changed from 'inline' to ''
Modified paths:
  • /trunk/extensions/SemanticForms/libs/SemanticForms.js (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticForms/libs/SemanticForms.js
@@ -199,7 +199,7 @@
200200 the_div = document.getElementById(div_id);
201201 for (var i in options_array) {
202202 if (the_input.value == options_array[i]) {
203 - the_div.style.display = 'inline';
 203+ the_div.style.display = ''; // return to default
204204 return;
205205 }
206206 }
@@ -213,7 +213,7 @@
214214 for (var i in checkbox_inputs) {
215215 checkbox = document.getElementById(checkbox_inputs[i]);
216216 if (checkbox.checked) {
217 - the_div.style.display = 'inline';
 217+ the_div.style.display = ''; // return to default
218218 return;
219219 }
220220 }

Status & tagging log