r73457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73456‎ | r73457 | r73458 >
Date:12:08, 21 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r73379
Modified paths:
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php (modified) (history)
  • /trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2Table.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2Table.php
@@ -75,13 +75,13 @@
7676 * Constructor.
7777 *
7878 * @param string $name
79 - * @param mixed $objectFields Array of string or a single string
 79+ * @param array $objectFields Associative array
8080 * @param mixed $indexes Array of string or a single string
8181 * @param mixed $fixedProperty string or false
8282 */
83 - public function __construct( $name, $objectFields, $indexes = array(), $fixedProperty = false ) {
 83+ public function __construct( $name, array $objectFields, $indexes = array(), $fixedProperty = false ) {
8484 $this->name = $name;
85 - $this->objectfields = (array)$objectFields;
 85+ $this->objectfields = $objectFields;
8686 $this->fixedproperty = $fixedProperty;
8787 $this->indexes = (array) $indexes;
8888 }
Index: trunk/extensions/SemanticMediaWiki/includes/storage/SMW_SQLStore2.php
@@ -1911,7 +1911,7 @@
19121912 }
19131913 }
19141914
1915 - $propertykey = ( $property->isUserDefined() ) ? $property->getDBkey():$property->getPropertyId();
 1915+ $propertykey = ( $property->isUserDefined() ) ? $property->getDBkey() : $property->getPropertyId();
19161916
19171917 if ( array_key_exists( $propertykey, self::$fixed_prop_tables ) ) {
19181918 $signature = self::getTypeSignature( $property->getPropertyTypeID() );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73379A bunch of small improvementsjeroendedauw14:33, 20 September 2010

Status & tagging log