r73452 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73451‎ | r73452 | r73453 >
Date:06:55, 21 September 2010
Author:reedy
Status:ok
Tags:
Comment:
Braces, spaces, and a few unused arrays
Modified paths:
  • /trunk/phase3/includes/User.php (modified) (history)
  • /trunk/phase3/includes/parser/Parser.php (modified) (history)
  • /trunk/phase3/languages/classes/LanguageKk.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/User.php
@@ -2761,9 +2761,9 @@
27622762 function getMaxID() {
27632763 static $res; // cache
27642764
2765 - if ( isset( $res ) )
 2765+ if ( isset( $res ) ) {
27662766 return $res;
2767 - else {
 2767+ } else {
27682768 $dbr = wfGetDB( DB_SLAVE );
27692769 return $res = $dbr->selectField( 'user', 'max(user_id)', false, __METHOD__ );
27702770 }
Index: trunk/phase3/includes/parser/Parser.php
@@ -3307,7 +3307,7 @@
33083308
33093309 if ( !$title->equals( $cacheTitle ) ) {
33103310 $this->mTplRedirCache[$cacheTitle->getPrefixedDBkey()] =
3311 - array( $title->getNamespace(),$cdb = $title->getDBkey() );
 3311+ array( $title->getNamespace(), $cdb = $title->getDBkey() );
33123312 }
33133313
33143314 return array( $dom, $title );
Index: trunk/phase3/languages/classes/LanguageKk.php
@@ -284,10 +284,10 @@
285285 }
286286
287287 function regsConverter( $text, $toVariant ) {
288 - if ( $text == '' ) return $text;
 288+ if ( $text == '' ) {
 289+ return $text;
 290+ }
289291
290 - $pat = array();
291 - $rep = array();
292292 switch( $toVariant ) {
293293 case 'kk-arab':
294294 case 'kk-cn':

Status & tagging log