r73420 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73419‎ | r73420 | r73421 >
Date:23:15, 20 September 2010
Author:dale
Status:deferred
Tags:
Comment:
added link to sequence page in publish summary
Modified paths:
  • /branches/MwEmbedStandAlone/modules/Sequencer/actions/mw.SequencerActionsSequence.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerServer.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/Sequencer/actions/mw.SequencerActionsSequence.js
@@ -35,7 +35,7 @@
3636 // XXX todo we should have an autocomplete on sequence name!
3737
3838 var buttons = {};
39 - buttons[ gM('mwe-cancel') ] = function(){ $j( this ).dialog( 'cancel' ) };
 39+ buttons[ gM('mwe-cancel') ] = function(){ $j( this ).dialog( 'cancel' ); };
4040
4141 // For now just support server based open .. ideally we could browse for file
4242 var $dialog = mw.addDialog({
@@ -80,7 +80,7 @@
8181 // Follow the link
8282 return true;
8383 })
84 - )
 84+ );
8585 },
8686 /**
8787 * present an open dialog to the user, and open the sequence in a new window
@@ -101,7 +101,7 @@
102102 // XXX todo we should have an autocomplete on sequence name!
103103
104104 var buttons = {};
105 - buttons[ gM('mwe-cancel') ] = function(){ $j( this ).dialog( 'cancel' ) };
 105+ buttons[ gM('mwe-cancel') ] = function(){ $j( this ).dialog( 'cancel' ); };
106106
107107 // For now just support server based open .. ideally we could browse for file
108108 var $dialog = mw.addDialog({
@@ -146,7 +146,7 @@
147147 // Follow the link
148148 return true;
149149 })
150 - )
 150+ );
151151 },
152152 save: function(){
153153 var _this = this;
@@ -167,7 +167,7 @@
168168 if( !_this.sequencer.getServer().hasLocalChanges() ){
169169 $dialog.html( gM('mwe-sequencer-save-no-changes') );
170170 var closeButton = {};
171 - closeButton[ gM('mwe-ok') ]= function(){ $j(this).dialog('close') };
 171+ closeButton[ gM('mwe-ok') ]= function(){ $j(this).dialog('close'); };
172172 $dialog.dialog( "option", "buttons", closeButton);
173173 return ;
174174 }
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerServer.js
@@ -406,7 +406,7 @@
407407 'action' : 'upload',
408408 'format': 'json',
409409 'filename': _this.getVideoFileName(),
410 - 'comment': 'Published Sequence: ' + saveSummary,
 410+ 'comment': 'Published [[' + _this.getTitleKey() + ']] : ' + saveSummary,
411411 'ignorewarnings' : true
412412 }
413413 // Return the apiUrl and request

Status & tagging log