r73418 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73417‎ | r73418 | r73419 >
Date:23:05, 20 September 2010
Author:dale
Status:deferred
Tags:
Comment:
added css rule to catch utf8 weirdness
Modified paths:
  • /branches/MwEmbedStandAlone/modules/Sequencer/tools/jPicker/css/jPicker-1.1.5.css (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/tools/jPicker/jpicker-1.1.5.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/Sequencer/tools/jPicker/jpicker-1.1.5.js
——@@ -13,8 +13,7 @@
1414 * Color Picker page: (http://johndyer.name/post/2007/09/PhotoShop-like-JavaScript-Color-Picker.aspx)
1515 *
1616 */
17 -(function($, version)
18 -{
 17+(function($, version) {
1918 Math.precision = function(value, precision)
2019 {
2120 if (precision === undefined) precision = 0;
——@@ -719,7 +718,7 @@
720719 function()
721720 {
722721 changeEvents = null;
723 - }
 722+ };
724723 $.extend(true, $this, // public properties and methods
725724 {
726725 val: val,
——@@ -1982,4 +1981,5 @@
19831982 }
19841983 }
19851984 };
 1985+
19861986 })(jQuery, '1.1.5');
\ No newline at end of file
Index: branches/MwEmbedStandAlone/modules/Sequencer/tools/jPicker/css/jPicker-1.1.5.css
——@@ -1,222 +1,226 @@
2 -.jPicker .Icon {
3 - display: inline-block;
4 - height: 24px; /* change this value if using a different sized color picker icon */
5 - position: relative; /* make this element an absolute positioning container */
6 - text-align: left; /* make the zero width children position to the left of container */
7 - width: 25px; /* change this value if using a different sized color picker icon */
8 -}
9 -.jPicker .Icon span.Color, .jPicker .Icon span.Alpha {
10 - background-position: 2px 2px;
11 - display: block;
12 - height: 100%;
13 - left: 0px;
14 - position: absolute;
15 - top: 0px;
16 - width: 100%;
17 -}
18 -.jPicker .Icon span.Image {
19 - background-repeat: no-repeat;
20 - cursor: pointer;
21 - display: block;
22 - height: 100%;
23 - left: 0px;
24 - position: absolute;
25 - top: 0px;
26 - width: 100%;
27 -}
28 -.jPicker.Container {
29 - z-index: 10;
30 -}
31 -table.jPicker {
32 - background-color: #efefef;
33 - border: 1px outset #666;
34 - font-family: Arial, Helvetica, Sans-Serif;
35 - font-size: 12px !important;
36 - margin: 0px;
37 - padding: 5px;
38 - width: 545px;
39 - z-index: 20;
40 -}
41 -.jPicker .Move {
42 - background-color: #dddddd;
43 - border-color: #fff #666 #666 #fff;
44 - border-style: solid;
45 - border-width: 1px;
46 - cursor: move;
47 - height: 12px;
48 - padding: 0px;
49 -}
50 -.jPicker .Title {
51 - font-size: 11px !important;
52 - font-weight: bold;
53 - margin: -2px 0px 0px 0px;
54 - padding: 0px;
55 - text-align: center;
56 - width: 100%;
57 -}
58 -.jPicker div.Map {
59 - border-bottom: 2px solid #fff;
60 - border-left: 2px solid #9a9a9a;
61 - border-right: 2px solid #fff;
62 - border-top: 2px solid #9a9a9a;
63 - cursor: crosshair;
64 - height: 260px; /* IE 6 incorrectly draws border inside the width and height instead of outside - We will fix this to 256px later */
65 - margin: 0px 5px 0px 5px;
66 - overflow: hidden; /* hide the overdraw of the Color Map icon when at edge of viewing box */
67 - padding: 0px;
68 - position: relative; /* make this element an absolute positioning container */
69 - width: 260px; /* IE 6 incorrectly draws border inside the width and height instead of outside - We will fix this to 256px later */
70 -}
71 -.jPicker div[class="Map"] {
72 - height: 256px; /* correct to 256px for browsers that support the "[class="xxx"]" selector (IE7+,Firefox,Safari,Chrome,Opera,etc.) */
73 - width: 256px; /* correct to 256px for browsers that support the "[class="xxx"]" selector (IE7+,Firefox,Safari,Chrome,Opera,etc.) */
74 -}
75 -.jPicker div.Bar {
76 - border-bottom: 2px solid #fff;
77 - border-left: 2px solid #9a9a9a;
78 - border-right: 2px solid #fff;
79 - border-top: 2px solid #9a9a9a;
80 - cursor: n-resize;
81 - height: 260px; /* IE 6 incorrectly draws border inside the width and height instead of outside - We will fix this to 256px later */
82 - margin: 12px 10px 0px 5px;
83 - overflow: hidden;
84 - padding: 0px;
85 - position: relative;
86 - width: 24px; /* IE 6 incorrectly draws border inside the width and height instead of outside - We will fix this to 20px later */
87 -}
88 -.jPicker div[class="Bar"] {
89 - height: 256px; /* correct to 256px for browsers that support the "[class="xxx"]" selector (IE7+,Firefox,Safari,Chrome,Opera,etc.) */
90 - width: 20px; /* correct to 20px for browsers that support the "[class="xxx"]" selector (IE7+,Firefox,Safari,Chrome,Opera,etc.) */
91 -}
92 -.jPicker .Map .Map1, .jPicker .Map .Map2, .jPicker .Map .Map3, .jPicker .Bar .Map1, .jPicker .Bar .Map2, .jPicker .Bar .Map3, .jPicker .Bar .Map4, .jPicker .Bar .Map5, .jPicker .Bar .Map6 {
93 - background-color: transparent;
94 - background-image: none;
95 - display: block;
96 - left: 0px;
97 - position: absolute;
98 - top: 0px;
99 -}
100 -.jPicker .Map .Map1, .jPicker .Map .Map2, .jPicker .Map .Map3 {
101 - height: 2596px;
102 - width: 256px; /* must specify pixel width. IE7/8 Quirks mode ignores opacity for an absolutely positioned item in a relative container with "overflow: visible". The marker in the colorBar
103 - would not be drawn if its overflow is set to hidden. */
104 -}
105 -.jPicker .Bar .Map1, .jPicker .Bar .Map2, .jPicker .Bar .Map3, .jPicker .Bar .Map4 {
106 - height: 3896px;
107 - width: 20px; /* must specify pixel width. IE7/8 Quirks mode ignores opacity for an absolutely positioned item in a relative container with "overflow: visible". The marker in the colorBar
108 - would not be drawn if its overflow is set to hidden. */
109 -}
110 -.jPicker .Bar .Map5, .jPicker .Bar .Map6 {
111 - height: 256px;
112 - width: 20px; /* must specify pixel width. IE7/8 Quirks mode ignores opacity for an absolutely positioned item in a relative container with "overflow: visible". The marker in the colorBar
113 - would not be drawn if its overflow is set to hidden. */
114 -}
115 -.jPicker .Map .Map1, .jPicker .Map .Map2, .jPicker .Bar .Map6 {
116 - background-repeat: no-repeat;
117 -}
118 -.jPicker .Map .Map3, .jPicker .Bar .Map5 {
119 - background-repeat: repeat;
120 -}
121 -.jPicker .Bar .Map1, .jPicker .Bar .Map2, .jPicker .Bar .Map3, .jPicker .Bar .Map4 {
122 - background-repeat: repeat-x;
123 -}
124 -.jPicker .Map .Arrow {
125 - display: block;
126 - position: absolute;
127 -}
128 -.jPicker .Bar .Arrow {
129 - display: block;
130 - left: 0px; /* (arrow width / 2) - (element width / 2) - position arrows' center in elements' center */
131 - position: absolute;
132 -}
133 -.jPicker .Preview {
134 - font-size: 9px;
135 - text-align: center;
136 -}
137 -.jPicker .Preview div {
138 - border: 2px inset #eee;
139 - height: 62px;
140 - margin: 0px auto;
141 - padding: 0px;
142 - width: 62px;
143 -}
144 -.jPicker .Preview div span {
145 - border: 1px solid #000;
146 - display: block;
147 - height: 30px;
148 - margin: 0px auto;
149 - padding: 0px;
150 - width: 60px;
151 -}
152 -.jPicker .Preview .Active {
153 - border-bottom-width: 0px;
154 -}
155 -.jPicker .Preview .Current {
156 - border-top-width: 0px;
157 - cursor: pointer;
158 -}
159 -.jPicker .Button {
160 - text-align: center;
161 - width: 115px;
162 -}
163 -.jPicker .Button input {
164 - width: 100px;
165 -}
166 -.jPicker .Button .Ok {
167 - margin: 12px 0px 5px 0px;
168 -}
169 -
170 -.jPicker td.Radio {
171 - margin: 0px;
172 - padding: 0px;
173 - width: 31px;
174 -}
175 -.jPicker td.Radio input {
176 - margin: 0px 5px 0px 0px;
177 - padding: 0px;
178 -}
179 -.jPicker td.Text {
180 - font-size: 12px !important;
181 - height: 22px;
182 - margin: 0px;
183 - padding: 0px;
184 - text-align: left;
185 - width: 70px;
186 -}
187 -.jPicker tr.Hex td.Text {
188 - width: 100px;
189 -}
190 -.jPicker td.Text input {
191 - background-color: #fff;
192 - border: 1px inset #aaa;
193 - height: 19px;
194 - margin: 0px 0px 0px 5px;
195 - text-align: left;
196 - width: 30px;
197 -}
198 -.jPicker td[class="Text"] input {
199 - height: 15px;
200 -}
201 -.jPicker tr.Hex td.Text input.Hex {
202 - width: 50px;
203 -}
204 -.jPicker tr.Hex td.Text input.AHex {
205 - width: 20px;
206 -}
207 -.jPicker .Grid {
208 - text-align: center;
209 - width: 114px;
210 -}
211 -.jPicker .Grid span.QuickColor {
212 - border: 1px inset #aaa;
213 - cursor: pointer;
214 - display: inline-block;
215 - height: 15px;
216 - line-height: 15px;
217 - margin: 0px;
218 - padding: 0px;
219 - width: 19px;
220 -}
221 -.jPicker .Grid span[class="QuickColor"] {
222 - width: 17px;
223 -}
\ No newline at end of file
 2+.jPicker .utf8bugCatcher{
 3+}
 4+
 5+.jPicker .Icon {
 6+ display: inline-block;
 7+ height: 24px; /* change this value if using a different sized color picker icon */
 8+ position: relative; /* make this element an absolute positioning container */
 9+ text-align: left; /* make the zero width children position to the left of container */
 10+ width: 25px; /* change this value if using a different sized color picker icon */
 11+}
 12+.jPicker .Icon span.Color, .jPicker .Icon span.Alpha {
 13+ background-position: 2px 2px;
 14+ display: block;
 15+ height: 100%;
 16+ left: 0px;
 17+ position: absolute;
 18+ top: 0px;
 19+ width: 100%;
 20+}
 21+.jPicker .Icon span.Image {
 22+ background-repeat: no-repeat;
 23+ cursor: pointer;
 24+ display: block;
 25+ height: 100%;
 26+ left: 0px;
 27+ position: absolute;
 28+ top: 0px;
 29+ width: 100%;
 30+}
 31+.jPicker.Container {
 32+ z-index: 10;
 33+}
 34+table.jPicker {
 35+ background-color: #efefef;
 36+ border: 1px outset #666;
 37+ font-family: Arial, Helvetica, Sans-Serif;
 38+ font-size: 12px !important;
 39+ margin: 0px;
 40+ padding: 5px;
 41+ width: 545px;
 42+ z-index: 20;
 43+}
 44+.jPicker .Move {
 45+ background-color: #dddddd;
 46+ border-color: #fff #666 #666 #fff;
 47+ border-style: solid;
 48+ border-width: 1px;
 49+ cursor: move;
 50+ height: 12px;
 51+ padding: 0px;
 52+}
 53+.jPicker .Title {
 54+ font-size: 11px !important;
 55+ font-weight: bold;
 56+ margin: -2px 0px 0px 0px;
 57+ padding: 0px;
 58+ text-align: center;
 59+ width: 100%;
 60+}
 61+.jPicker div.Map {
 62+ border-bottom: 2px solid #fff;
 63+ border-left: 2px solid #9a9a9a;
 64+ border-right: 2px solid #fff;
 65+ border-top: 2px solid #9a9a9a;
 66+ cursor: crosshair;
 67+ height: 260px; /* IE 6 incorrectly draws border inside the width and height instead of outside - We will fix this to 256px later */
 68+ margin: 0px 5px 0px 5px;
 69+ overflow: hidden; /* hide the overdraw of the Color Map icon when at edge of viewing box */
 70+ padding: 0px;
 71+ position: relative; /* make this element an absolute positioning container */
 72+ width: 260px; /* IE 6 incorrectly draws border inside the width and height instead of outside - We will fix this to 256px later */
 73+}
 74+.jPicker div[class="Map"] {
 75+ height: 256px; /* correct to 256px for browsers that support the "[class="xxx"]" selector (IE7+,Firefox,Safari,Chrome,Opera,etc.) */
 76+ width: 256px; /* correct to 256px for browsers that support the "[class="xxx"]" selector (IE7+,Firefox,Safari,Chrome,Opera,etc.) */
 77+}
 78+.jPicker div.Bar {
 79+ border-bottom: 2px solid #fff;
 80+ border-left: 2px solid #9a9a9a;
 81+ border-right: 2px solid #fff;
 82+ border-top: 2px solid #9a9a9a;
 83+ cursor: n-resize;
 84+ height: 260px; /* IE 6 incorrectly draws border inside the width and height instead of outside - We will fix this to 256px later */
 85+ margin: 12px 10px 0px 5px;
 86+ overflow: hidden;
 87+ padding: 0px;
 88+ position: relative;
 89+ width: 24px; /* IE 6 incorrectly draws border inside the width and height instead of outside - We will fix this to 20px later */
 90+}
 91+.jPicker div[class="Bar"] {
 92+ height: 256px; /* correct to 256px for browsers that support the "[class="xxx"]" selector (IE7+,Firefox,Safari,Chrome,Opera,etc.) */
 93+ width: 20px; /* correct to 20px for browsers that support the "[class="xxx"]" selector (IE7+,Firefox,Safari,Chrome,Opera,etc.) */
 94+}
 95+.jPicker .Map .Map1, .jPicker .Map .Map2, .jPicker .Map .Map3, .jPicker .Bar .Map1, .jPicker .Bar .Map2, .jPicker .Bar .Map3, .jPicker .Bar .Map4, .jPicker .Bar .Map5, .jPicker .Bar .Map6 {
 96+ background-color: transparent;
 97+ background-image: none;
 98+ display: block;
 99+ left: 0px;
 100+ position: absolute;
 101+ top: 0px;
 102+}
 103+.jPicker .Map .Map1, .jPicker .Map .Map2, .jPicker .Map .Map3 {
 104+ height: 2596px;
 105+ width: 256px; /* must specify pixel width. IE7/8 Quirks mode ignores opacity for an absolutely positioned item in a relative container with "overflow: visible". The marker in the colorBar
 106+ would not be drawn if its overflow is set to hidden. */
 107+}
 108+.jPicker .Bar .Map1, .jPicker .Bar .Map2, .jPicker .Bar .Map3, .jPicker .Bar .Map4 {
 109+ height: 3896px;
 110+ width: 20px; /* must specify pixel width. IE7/8 Quirks mode ignores opacity for an absolutely positioned item in a relative container with "overflow: visible". The marker in the colorBar
 111+ would not be drawn if its overflow is set to hidden. */
 112+}
 113+.jPicker .Bar .Map5, .jPicker .Bar .Map6 {
 114+ height: 256px;
 115+ width: 20px; /* must specify pixel width. IE7/8 Quirks mode ignores opacity for an absolutely positioned item in a relative container with "overflow: visible". The marker in the colorBar
 116+ would not be drawn if its overflow is set to hidden. */
 117+}
 118+.jPicker .Map .Map1, .jPicker .Map .Map2, .jPicker .Bar .Map6 {
 119+ background-repeat: no-repeat;
 120+}
 121+.jPicker .Map .Map3, .jPicker .Bar .Map5 {
 122+ background-repeat: repeat;
 123+}
 124+.jPicker .Bar .Map1, .jPicker .Bar .Map2, .jPicker .Bar .Map3, .jPicker .Bar .Map4 {
 125+ background-repeat: repeat-x;
 126+}
 127+.jPicker .Map .Arrow {
 128+ display: block;
 129+ position: absolute;
 130+}
 131+.jPicker .Bar .Arrow {
 132+ display: block;
 133+ left: 0px; /* (arrow width / 2) - (element width / 2) - position arrows' center in elements' center */
 134+ position: absolute;
 135+}
 136+.jPicker .Preview {
 137+ font-size: 9px;
 138+ text-align: center;
 139+}
 140+.jPicker .Preview div {
 141+ border: 2px inset #eee;
 142+ height: 62px;
 143+ margin: 0px auto;
 144+ padding: 0px;
 145+ width: 62px;
 146+}
 147+.jPicker .Preview div span {
 148+ border: 1px solid #000;
 149+ display: block;
 150+ height: 30px;
 151+ margin: 0px auto;
 152+ padding: 0px;
 153+ width: 60px;
 154+}
 155+.jPicker .Preview .Active {
 156+ border-bottom-width: 0px;
 157+}
 158+.jPicker .Preview .Current {
 159+ border-top-width: 0px;
 160+ cursor: pointer;
 161+}
 162+.jPicker .Button {
 163+ text-align: center;
 164+ width: 115px;
 165+}
 166+.jPicker .Button input {
 167+ width: 100px;
 168+}
 169+.jPicker .Button .Ok {
 170+ margin: 12px 0px 5px 0px;
 171+}
 172+
 173+.jPicker td.Radio {
 174+ margin: 0px;
 175+ padding: 0px;
 176+ width: 31px;
 177+}
 178+.jPicker td.Radio input {
 179+ margin: 0px 5px 0px 0px;
 180+ padding: 0px;
 181+}
 182+.jPicker td.Text {
 183+ font-size: 12px !important;
 184+ height: 22px;
 185+ margin: 0px;
 186+ padding: 0px;
 187+ text-align: left;
 188+ width: 70px;
 189+}
 190+.jPicker tr.Hex td.Text {
 191+ width: 100px;
 192+}
 193+.jPicker td.Text input {
 194+ background-color: #fff;
 195+ border: 1px inset #aaa;
 196+ height: 19px;
 197+ margin: 0px 0px 0px 5px;
 198+ text-align: left;
 199+ width: 30px;
 200+}
 201+.jPicker td[class="Text"] input {
 202+ height: 15px;
 203+}
 204+.jPicker tr.Hex td.Text input.Hex {
 205+ width: 50px;
 206+}
 207+.jPicker tr.Hex td.Text input.AHex {
 208+ width: 20px;
 209+}
 210+.jPicker .Grid {
 211+ text-align: center;
 212+ width: 114px;
 213+}
 214+.jPicker .Grid span.QuickColor {
 215+ border: 1px inset #aaa;
 216+ cursor: pointer;
 217+ display: inline-block;
 218+ height: 15px;
 219+ line-height: 15px;
 220+ margin: 0px;
 221+ padding: 0px;
 222+ width: 19px;
 223+}
 224+.jPicker .Grid span[class="QuickColor"] {
 225+ width: 17px;
 226+}
 227+

Status & tagging log