r73378 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73377‎ | r73378 | r73379 >
Date:14:33, 20 September 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.7 - small improvements
Modified paths:
  • /trunk/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/includes/queryprinters/SM_Mapper.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/includes/SM_GeoCoordsValue.php
@@ -1,29 +1,17 @@
22 <?php
 3+
34 /**
4 - * File holding the SMGeoCoordsValue class.
 5+ * Implementation of datavalues that are geographic coordinates.
56 *
 7+ * @since 0.6
 8+ *
69 * @file SM_GeoCoordsValue.php
7 - * @ingroup SMWDataValues
810 * @ingroup SemanticMaps
 11+ * @ingroup SMWDataValues
912 *
1013 * @author Jeroen De Dauw
1114 * @author Markus Krötzsch
1215 */
13 -
14 -if ( !defined( 'MEDIAWIKI' ) ) {
15 - die( 'Not an entry point.' );
16 -}
17 -
18 -/**
19 - * Implementation of datavalues that are geographic coordinates.
20 - *
21 - * @author Jeroen De Dauw
22 - * @author Markus Krötzsch
23 - *
24 - * @since 0.6
25 - *
26 - * @ingroup SemanticMaps
27 - */
2816 class SMGeoCoordsValue extends SMWDataValue {
2917
3018 protected $coordinateSet;
Index: trunk/extensions/SemanticMaps/includes/forminputs/SM_FormInput.php
@@ -8,11 +8,6 @@
99 *
1010 * @author Jeroen De Dauw
1111 */
12 -
13 -if ( !defined( 'MEDIAWIKI' ) ) {
14 - die( 'Not an entry point.' );
15 -}
16 -
1712 abstract class SMFormInput implements iMappingFeature {
1813
1914 /**
Index: trunk/extensions/SemanticMaps/includes/queryprinters/SM_Mapper.php
@@ -1,18 +1,13 @@
22 <?php
33
44 /**
5 - * General map query printer class
 5+ * General map query printer class.
66 *
77 * @file SM_Mapper.php
88 * @ingroup SemanticMaps
99 *
1010 * @author Jeroen De Dauw
1111 */
12 -
13 -if ( !defined( 'MEDIAWIKI' ) ) {
14 - die( 'Not an entry point.' );
15 -}
16 -
1712 final class SMMapper {
1813
1914 /**

Status & tagging log