r73375 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73374‎ | r73375 | r73376 >
Date:13:35, 20 September 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Coding style
Modified paths:
  • /trunk/phase3/includes/specials/SpecialShortpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialShortpages.php
@@ -72,11 +72,13 @@
7373 # the page must exist for it to have been pulled out of the table
7474 if( $this->isCached() ) {
7575 $batch = new LinkBatch();
76 - while( $row = $db->fetchObject( $res ) )
 76+ foreach ( $res as $row ) {
7777 $batch->add( $row->namespace, $row->title );
 78+ }
7879 $batch->execute();
79 - if( $db->numRows( $res ) > 0 )
 80+ if ( $db->numRows( $res ) > 0 ) {
8081 $db->dataSeek( $res, 0 );
 82+ }
8183 }
8284 }
8385

Status & tagging log