r73350 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73349‎ | r73350 | r73351 >
Date:23:27, 19 September 2010
Author:sergeychernyshev
Status:deferred
Tags:
Comment:
Fixed validation comparison for a falsy string (bug 25219)
Modified paths:
  • /trunk/extensions/Widgets/smarty_plugins/modifier.validate.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Widgets/smarty_plugins/modifier.validate.php
@@ -21,7 +21,7 @@
2222 'ip' => FILTER_VALIDATE_IP
2323 );
2424
25 - if (array_key_exists($type, $filters) && filter_var($string, $filters[$type]))
 25+ if (array_key_exists($type, $filters) && filter_var($string, $filters[$type]) !== FALSE)
2626 {
2727 return $string;
2828 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r73353Some code structure changes and fix to a bug 25219sergeychernyshev23:39, 19 September 2010

Status & tagging log