r73236 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73235‎ | r73236 | r73237 >
Date:18:27, 17 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
we don't need to instantiate CentralNoticeDB, all of it's functions are static
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -4,7 +4,6 @@
55 * Generates Javascript file which controls banner selection on the client side
66 */
77 class SpecialBannerController extends UnlistedSpecialPage {
8 - public $centralNoticeDB;
98 protected $sharedMaxAge = 7200; // Cache for 2 hours on the server side
109 protected $maxAge = 7200; // Cache for 2 hours on the client side
1110 protected $contentType = 'text/javascript';
@@ -12,7 +11,6 @@
1312 function __construct() {
1413 // Register special page
1514 parent::__construct( "BannerController" );
16 - $this->centralNoticeDB = new CentralNoticeDB();
1715 }
1816
1917 function execute( $par ) {

Status & tagging log