r73180 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73179‎ | r73180 | r73181 >
Date:23:41, 16 September 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Brought code from WikiEditor extension in, reorganized module/feature definitions
Modified paths:
  • /trunk/extensions/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/WikiEditor.hooks.php
——@@ -8,9 +8,9 @@
99
1010 class WikiEditorHooks {
1111
12 - /* Static Members */
 12+ /* Protected Static Members */
1313
14 - static $modules = array(
 14+ protected static $modules = array(
1515
1616 /* Third-party modules */
1717
——@@ -391,7 +391,7 @@
392392 ),
393393 );
394394
395 - static $features = array(
 395+ protected static $features = array(
396396
397397 /* Beta Features */
398398
——@@ -585,8 +585,7 @@
586586 *
587587 * Adds the modules to the edit form
588588 *
589 - * @param $out OutputPage output page
590 - * @param $skin Skin current skin
 589+ * @param $toolbar array list of toolbar items
591590 */
592591 public static function editPageShowEditFormInitial( &$toolbar ) {
593592 global $wgOut;

Comments

#Comment by Catrope (talk | contribs)   18:12, 1 October 2010

What this commit promised to do was done in r73181.

#Comment by Trevor Parscal (WMF) (talk | contribs)   19:28, 1 October 2010

I think I accidentally re-used the same commit line. This was clearly just making trivial adjustments.

Status & tagging log