r73178 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73177‎ | r73178 | r73179 >
Date:23:26, 16 September 2010
Author:demon
Status:resolved (Comments)
Tags:
Comment:
Fix a bunch of notices. Error was "Notice: Found alias defined for (some uppercased special page) when searching forspecial page aliases for (some lowercased special page). Case mismatch?"
Modified paths:
  • /trunk/phase3/includes/Skin.php (modified) (history)
  • /trunk/phase3/skins/CologneBlue.php (modified) (history)
  • /trunk/phase3/skins/Nostalgia.php (modified) (history)
  • /trunk/phase3/skins/Standard.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/CologneBlue.php
@@ -156,7 +156,7 @@
157157 Title::newFromText( wfMsgForContent( 'faqpage' ) ),
158158 wfMsg( 'faq' )
159159 ),
160 - $this->specialLink( 'specialpages' )
 160+ $this->specialLink( 'Specialpages' )
161161 );
162162
163163 /* show links to different language variants */
@@ -288,7 +288,7 @@
289289 array(),
290290 array(),
291291 array( 'known', 'noclasses' )
292 - ) . $sep . $tl . $sep . $this->specialLink( 'watchlist' )
 292+ ) . $sep . $tl . $sep . $this->specialLink( 'Watchlist' )
293293 . $sep .
294294 $this->link(
295295 SpecialPage::getSafeTitleFor( 'Contributions', $wgUser->getName() ),
@@ -296,16 +296,16 @@
297297 array(),
298298 array(),
299299 array( 'known', 'noclasses' )
300 - ) . $sep . $this->specialLink( 'preferences' )
301 - . $sep . $this->specialLink( 'userlogout' );
 300+ ) . $sep . $this->specialLink( 'Preferences' )
 301+ . $sep . $this->specialLink( 'Userlogout' );
302302 } else {
303 - $s .= $this->specialLink( 'userlogin' );
 303+ $s .= $this->specialLink( 'Userlogin' );
304304 }
305305
306306 $s .= $this->menuHead( 'qbspecialpages' )
307 - . $this->specialLink( 'newpages' )
308 - . $sep . $this->specialLink( 'listfiles' )
309 - . $sep . $this->specialLink( 'statistics' );
 307+ . $this->specialLink( 'Newpages' )
 308+ . $sep . $this->specialLink( 'Listfiles' )
 309+ . $sep . $this->specialLink( 'Statistics' );
310310 if( UploadBase::isEnabled() && UploadBase::isAllowed( $wgUser ) === true ) {
311311 $s .= $sep . $this->getUploadLink();
312312 }
Index: trunk/phase3/skins/Standard.php
@@ -81,7 +81,7 @@
8282 $s .= "\n<br />" . $wgLang->pipeList( array(
8383 $this->mainPageLink(),
8484 $this->aboutLink(),
85 - $this->specialLink( 'recentchanges' ),
 85+ $this->specialLink( 'Recentchanges' ),
8686 $this->searchForm() ) )
8787 . '<br /><span id="pagestats">' . $this->pageStats() . '</span>';
8888
@@ -130,7 +130,7 @@
131131 }
132132
133133 if( $wgUser->isLoggedIn() ) {
134 - $s.= $this->specialLink( 'watchlist' ) ;
 134+ $s.= $this->specialLink( 'Watchlist' ) ;
135135 $s .= $sep . $this->linkKnown(
136136 SpecialPage::getTitleFor( 'Contributions' ),
137137 wfMsg( 'mycontris' ),
@@ -267,7 +267,7 @@
268268 $s .= $this->getUploadLink() . $sep;
269269 }
270270
271 - $s .= $this->specialLink( 'specialpages' );
 271+ $s .= $this->specialLink( 'Specialpages' );
272272
273273 global $wgSiteSupportPage;
274274 if( $wgSiteSupportPage ) {
Index: trunk/phase3/skins/Nostalgia.php
@@ -61,7 +61,7 @@
6262 $sep = " |\n";
6363
6464 $s = $this->mainPageLink() . $sep
65 - . $this->specialLink( 'recentchanges' );
 65+ . $this->specialLink( 'Recentchanges' );
6666
6767 if ( $wgOut->isArticle() ) {
6868 $s .= $sep . '<strong>' . $this->editThisPage() . '</strong>' . $sep . $this->historyLink();
@@ -71,7 +71,7 @@
7272 $s .= $this->variantLinks();
7373 $s .= $this->extensionTabLinks();
7474 if ( $wgUser->isAnon() ) {
75 - $s .= $sep . $this->specialLink( 'userlogin' );
 75+ $s .= $sep . $this->specialLink( 'Watchlist' );
7676 } else {
7777 /* show user page and user talk links */
7878 $s .= $sep . $this->link( $wgUser->getUserPage(), wfMsgHtml( 'mypage' ) );
@@ -80,20 +80,20 @@
8181 $s .= ' *';
8282 }
8383 /* show watchlist link */
84 - $s .= $sep . $this->specialLink( 'watchlist' );
 84+ $s .= $sep . $this->specialLink( 'Watchlist' );
8585 /* show my contributions link */
8686 $s .= $sep . $this->link(
8787 SpecialPage::getSafeTitleFor( 'Contributions', $wgUser->getName() ),
8888 wfMsgHtml( 'mycontris' ) );
8989 /* show my preferences link */
90 - $s .= $sep . $this->specialLink( 'preferences' );
 90+ $s .= $sep . $this->specialLink( 'Preferences' );
9191 /* show upload file link */
9292 if( UploadBase::isEnabled() && UploadBase::isAllowed( $wgUser ) === true ) {
9393 $s .= $sep . $this->getUploadLink();
9494 }
9595
9696 /* show log out link */
97 - $s .= $sep . $this->specialLink( 'userlogout' );
 97+ $s .= $sep . $this->specialLink( 'Userlogout' );
9898 }
9999
100100 $s .= $sep . $this->specialPagesList();
Index: trunk/phase3/includes/Skin.php
@@ -1160,7 +1160,7 @@
11611161 SpecialPage::getTitleFor( 'Userlogout' ), wfMsg( 'logout' ),
11621162 array(), array( 'returnto' => $returnTo )
11631163 ),
1164 - $this->specialLink( 'preferences' ),
 1164+ $this->specialLink( 'Preferences' ),
11651165 ) );
11661166 }
11671167
@@ -1214,7 +1214,7 @@
12151215
12161216 $s = array(
12171217 $this->mainPageLink(),
1218 - $this->specialLink( 'recentchanges' )
 1218+ $this->specialLink( 'Recentchanges' )
12191219 );
12201220
12211221 if ( $wgOut->isArticleRelated() ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r75168follow-up to r73178: fix copypaste mistakeashley20:42, 21 October 2010

Comments

#Comment by Jack Phoenix (talk | contribs)   20:45, 21 October 2010

Copypaste mistake fixed in r75168.

Status & tagging log