r73170 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73169‎ | r73170 | r73171 >
Date:22:57, 16 September 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Added embed tags to CSS image URLs
Modified paths:
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.css (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.previewDialog.css (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toc.css (modified) (history)
  • /trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css (modified) (history)
  • /trunk/extensions/WikiEditor/modules/wikiEditor.dialogs.css (modified) (history)

Diff [purge]

Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.css
——@@ -111,6 +111,7 @@
112112 display: block;
113113 height: 24px;
114114 width: 24px;
 115+ /* @embed */
115116 background: url(images/toolbar/loading.gif) 0 0 no-repeat;
116117 text-indent: -9999px;
117118 margin: 0 auto;
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.previewDialog.css
——@@ -19,6 +19,7 @@
2020 display: block;
2121 height: 24px;
2222 width: 24px;
 23+ /* @embed */
2324 background: url(images/toolbar/loading.gif) 0 0 no-repeat;
2425 text-indent: -9999px;
2526 margin: 50px auto;
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css
——@@ -24,16 +24,11 @@
2525 background-color: #E0EEf7;
2626 }
2727 .wikiEditor-ui-toolbar {
 28+ /* @embed */
2829 background-image: url(images/toolbar/base.png);
2930 background-position: left top;
3031 background-repeat: repeat-x;
3132 }
32 -/*
33 -.wikiEditor-ui-toolbar .toolbar {
34 - background-image: url(../images/wikiEditor/toolbar/base.png?1);
35 - background-position: left top;
36 -}
37 -*/
3833 body.rtl .wikiEditor-ui-toolbar .sections .section {
3934 float: right;
4035 }
——@@ -43,6 +38,7 @@
4439 }
4540 .wikiEditor-ui-toolbar .sections .loading .spinner {
4641 display: block;
 42+ /* @embed */
4743 background-image: url(images/toolbar/loading.gif);
4844 background-position: left center;
4945 background-repeat: no-repeat;
——@@ -106,6 +102,7 @@
107103 }
108104 /* Sprited Buttons */
109105 .wikiEditor-toolbar-spritedButton {
 106+ /* @embed */
110107 background: url(images/toolbar/button-sprite.png) 0 0 no-repeat;
111108 display: block;
112109 float: left;
——@@ -143,6 +140,7 @@
144141 height: 26px;
145142 cursor: pointer;
146143 color: #0645ad;
 144+ /* @embed */
147145 background-image: url(images/toolbar/arrow-right.png);
148146 background-position: left center;
149147 background-repeat: no-repeat;
——@@ -151,6 +149,7 @@
152150 body.rtl .wikiEditor-ui-toolbar .tabs span.tab a:visited {
153151 padding-left: 12px;
154152 padding-right: 18px;
 153+ /* @embed */
155154 background-image: url(images/toolbar/arrow-left.png);
156155 background-position: right center;
157156 }
——@@ -162,16 +161,19 @@
163162 .wikiEditor-ui-toolbar .tabs span.tab a.current,
164163 .wikiEditor-ui-toolbar .tabs span.tab a.current:visited {
165164 color: #333333;
 165+ /* @embed */
166166 background-image: url(images/toolbar/arrow-down.png);
167167 }
168168 body.rtl .wikiEditor-ui-toolbar .tabs span.tab a.current,
169169 body.rtl .wikiEditor-ui-toolbar .tabs span.tab a.current:visited {
 170+ /* @embed */
170171 background-image: url(images/toolbar/arrow-down.png);
171172 }
172173 .wikiEditor-ui-toolbar .tabs span.tab a.current:hover {
173174 text-decoration: none;
174175 }
175176 .wikiEditor-ui-toolbar .tabs span.tab a.loading {
 177+ /* @embed */
176178 background-image: url(images/toolbar/loading-small.gif) !important;
177179 }
178180 /* Toolbar */
——@@ -220,6 +222,7 @@
221223 float: right;
222224 }
223225 .wikiEditor-ui-toolbar .group .tool-select .label {
 226+ /* @embed */
224227 background-image: url(images/toolbar/arrow-down.png);
225228 background-position: center right;
226229 background-repeat: no-repeat;
Index: trunk/extensions/WikiEditor/modules/wikiEditor.dialogs.css
——@@ -76,15 +76,19 @@
7777 background-repeat: no-repeat;
7878 }
7979 #wikieditor-toolbar-link-int-target-status-exists {
 80+ /* @embed */
8081 background-image: url(images/dialogs/insert-link-exists.png);
8182 }
8283 #wikieditor-toolbar-link-int-target-status-notexists {
 84+ /* @embed */
8385 background-image: url(images/dialogs/insert-link-notexists.png);
8486 }
8587 #wikieditor-toolbar-link-int-target-status-invalid {
 88+ /* @embed */
8689 background-image: url(images/dialogs/insert-link-invalid.png);
8790 }
8891 #wikieditor-toolbar-link-int-target-status-external {
 92+ /* @embed */
8993 background-image: url(images/dialogs/insert-link-external.png);
9094 }
9195 /* Reference Dialog */
——@@ -127,6 +131,7 @@
128132 background-position: 100% 50%;
129133 }
130134 body.rtl #wikieditor-toolbar-link-int-target-status-external {
 135+ /* @embed */
131136 background-image: url(images/dialogs/insert-link-external-rtl.png);
132137 }
133138 body.rtl #wikieditor-toolbar-reference-dialog label {
Index: trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toc.css
——@@ -28,6 +28,7 @@
2929 }
3030 .tab-toc {
3131 /* Should match the toolbar */
 32+ /* @embed */
3233 background-image: url(images/toolbar/base.png);
3334 background-position: left top;
3435 background-repeat: repeat-x;
——@@ -141,10 +142,12 @@
142143 left: 0;
143144 }
144145 .wikiEditor-ui-toc-collapse-open {
 146+ /* @embed */
145147 background: #f3f3f3 url(images/toc/close.png) 4px 50% no-repeat;
146148 border-left: 1px solid #DDDDDD;
147149 }
148150 .wikiEditor-ui-toc-collapse-closed {
 151+ /* @embed */
149152 background: #f3f3f3 url(images/toc/open.png) 4px 50% no-repeat;
150153 }
151154 /* Resizing Changes */
——@@ -172,6 +175,7 @@
173176 top: 7px;
174177 left: -12px !important;
175178 cursor: ew-resize;
 179+ /* @embed */
176180 background: url(images/toc/grip.png) 50% 50% no-repeat;
177181 z-index: 0;
178182 }

Comments

#Comment by Krinkle (talk | contribs)   01:53, 22 January 2011

The commit message didn't say anything about the block what was removed. Could you comment on that ? 

--- trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css
+++ trunk/extensions/WikiEditor/modules/jquery.wikiEditor.toolbar.css
-/*
-.wikiEditor-ui-toolbar .toolbar {
-	background-image: url(../images/wikiEditor/toolbar/base.png?1);
-	background-position: left top;
-}
-*/
#Comment by Trevor Parscal (WMF) (talk | contribs)   21:41, 25 January 2011

It was superflous - it should have been mentioned in the comment.

#Comment by Krinkle (talk | contribs)   21:52, 25 January 2011

Sometimes changes are committed by accident. Just making sure :)

Marking as ok.

Status & tagging log