r73138 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73137‎ | r73138 | r73139 >
Date:18:35, 16 September 2010
Author:catrope
Status:deferred
Tags:
Comment:
ArticleAssessmentPilot: Fix bug that caused the staleness message to never display
Modified paths:
  • /trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.hooks.php (modified) (history)
  • /trunk/extensions/ArticleAssessmentPilot/js/ArticleAssessment.js (modified) (history)

Diff [purge]

Index: trunk/extensions/ArticleAssessmentPilot/ArticleAssessmentPilot.hooks.php
@@ -12,7 +12,7 @@
1313 );
1414
1515 private static $scriptFiles = array(
16 - array( 'src' => 'js/ArticleAssessment.js', 'version' => 1 ),
 16+ array( 'src' => 'js/ArticleAssessment.js', 'version' => 2 ),
1717 array( 'src' => 'js/jquery.cookie.js', 'version' => 1 ),
1818 array( 'src' => 'js/jquery.tipsy.js', 'version' => 1 ),
1919 array( 'src' => 'js/jquery.stars.js', 'version' => 1 ),
Index: trunk/extensions/ArticleAssessmentPilot/js/ArticleAssessment.js
@@ -279,7 +279,7 @@
280280 }
281281 }
282282 // if the rating is more than 5 revisions old, mark it as stale
283 - if( data.query.articleassessment.stale ) {
 283+ if ( typeof data.query.articleassessment[0].stale != 'undefined' ) {
284284 // add the stale star class to each on star
285285 $( '.ui-stars-star-on' )
286286 .addClass( 'ui-stars-star-stale' );

Status & tagging log