r73116 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73115‎ | r73116 | r73117 >
Date:15:47, 16 September 2010
Author:catrope
Status:deferred (Comments)
Tags:
Comment:
SimpleSurvey: Put the success message in <strong class="simplesurvey-success"></strong> so ArticleAssessment can detect a successful submission. This screenscraping is absolutely horrible but it's easy and fast, and that's what we need right now.
Modified paths:
  • /trunk/extensions/SimpleSurvey/SpecialSimpleSurvey.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SimpleSurvey/SpecialSimpleSurvey.php
——@@ -55,7 +55,7 @@
5656 if ( $wgRequest->wasPosted() ) {
5757 if ( $surveyName && in_array( $surveyName, $wgValidSurveys ) && $this->checkToken() ) {
5858 SimpleSurvey::save( $surveyName, $wgPrefSwitchSurveys[$surveyName] );
59 - $wgOut->addHtml( "<b>" . wfMsg( 'simple-survey-confirm' ) . "</b>" );
 59+ $wgOut->addHtml( '<strong class="simplesurvey-success">' . wfMsg( 'simple-survey-confirm' ) . '</strong>' );
6060 }
6161 // forward to new page
6262 if ( $wgSimpleSurveyRedirectURL ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r73121SimpleSurvey: Escape message per r73116 CRcatrope16:13, 16 September 2010

Comments

#Comment by Nikerabbit (talk | contribs)   16:10, 16 September 2010

Unescaped messages?

#Comment by Catrope (talk | contribs)   16:13, 16 September 2010

Good catch. Fixed in r73121.

Status & tagging log