r73115 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73114‎ | r73115 | r73116 >
Date:13:45, 16 September 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 25182) ResourceLoader breaks because of warnings thrown when an open_basedir is set. Fix is untested, asking reporter to confirm
Modified paths:
  • /trunk/phase3/includes/libs/CSSMin.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/libs/CSSMin.php
——@@ -66,7 +66,7 @@
6767 $file = ( isset( $path ) ? rtrim( $path, '/' ) . '/' : '' ) . "{$match['file'][0]}";
6868
6969 // Only proceed if we can access the file
70 - if ( file_exists( $file ) ) {
 70+ if ( !is_null( $path ) && file_exists( $file ) ) {
7171 $files[] = $file;
7272 }
7373 }

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   23:20, 24 September 2010

Reported claims this worked.

Status & tagging log