r73097 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73096‎ | r73097 | r73098 >
Date:22:44, 15 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
setting cache controls for banner loading infrastructure
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)
  • /trunk/extensions/CentralNotice/SpecialBannerListLoader.php (modified) (history)
  • /trunk/extensions/CentralNotice/SpecialBannerLoader.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialBannerListLoader.php
@@ -8,8 +8,8 @@
99 public $language; // Project language
1010 public $location; // User country
1111 public $centralNoticeDB;
12 - protected $sharedMaxAge = 150; // Cache for ? minutes on the server side
13 - protected $maxAge = 150; // Cache for ? minutes on the client side
 12+ protected $sharedMaxAge = 900; // Cache for 15 minutes on the server side
 13+ protected $maxAge = 900; // Cache for 15 minutes on the client side
1414 protected $contentType = 'text/javascript';
1515
1616 function __construct() {
Index: trunk/extensions/CentralNotice/SpecialBannerLoader.php
@@ -6,7 +6,7 @@
77 class SpecialBannerLoader extends UnlistedSpecialPage {
88 public $siteName = 'Wikipedia'; // Site name
99 public $language = 'en'; // User language
10 - protected $sharedMaxAge = 150; // Cache for 2 hours on the server side
 10+ protected $sharedMaxAge = 900; // Cache for 15 minutes on the server side
1111 protected $maxAge = 0; // No client-side banner caching so we get all impressions
1212 protected $contentType = 'text/html';
1313
Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -5,8 +5,8 @@
66 */
77 class SpecialBannerController extends UnlistedSpecialPage {
88 public $centralNoticeDB;
9 - protected $sharedMaxAge = 150; // Cache for ? minutes on the server side
10 - protected $maxAge = 150; // Cache for ? minutes on the client side
 9+ protected $sharedMaxAge = 7200; // Cache for 2 hours on the server side
 10+ protected $maxAge = 7200; // Cache for 2 hours on the client side
1111 protected $contentType = 'text/javascript';
1212
1313 function __construct() {

Status & tagging log