r73082 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73081‎ | r73082 | r73083 >
Date:19:49, 15 September 2010
Author:platonides
Status:ok
Tags:
Comment:
Follow up r71805: Drop PoolWork from the configuration key, and update DefaultSettings comment, document workers, maxqueue and timeout parameters.
Modified paths:
  • /trunk/extensions/PoolCounter/PoolCounterClient.php (modified) (history)
  • /trunk/phase3/includes/Article.php (modified) (history)
  • /trunk/phase3/includes/DefaultSettings.php (modified) (history)
  • /trunk/phase3/includes/PoolCounter.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Article.php
@@ -4455,7 +4455,6 @@
44564456 *
44574457 * @param $parserOutput mixed ParserOptions object, or boolean false
44584458 **/
4459 -
44604459 protected function doCascadeProtectionUpdates( $parserOutput ) {
44614460 if ( !$this->isCurrent() || wfReadOnly() || !$this->mTitle->areRestrictionsCascading() ) {
44624461 return;
@@ -4623,7 +4622,7 @@
46244623 private $mArticle;
46254624
46264625 function __construct( $article, $key, $useParserCache, $parserOptions ) {
4627 - parent::__construct( __CLASS__, $key );
 4626+ parent::__construct( 'ArticleView', $key );
46284627 $this->mArticle = $article;
46294628 $this->cacheable = $useParserCache;
46304629 $this->parserOptions = $parserOptions;
Index: trunk/phase3/includes/PoolCounter.php
@@ -9,8 +9,10 @@
1010 * of the cpu of the pool. This is also known as 'Michael Jackson effect'.
1111 * The PoolCounter provides semaphore semantics for restricting the number
1212 * of workers that may be concurrently performing such single task.
 13+ *
 14+ * By default PoolCounter_Stub is used, which provides no locking. You
 15+ * can get a useful one in the PoolCounter extension.
1316 */
14 -
1517 abstract class PoolCounter {
1618
1719 /* Return codes */
Index: trunk/phase3/includes/DefaultSettings.php
@@ -5070,8 +5070,11 @@
50715071 * The remaining elements are passed through to the class as constructor
50725072 * parameters. Example:
50735073 *
5074 - * $wgPoolCounterConf = array( 'Article::view' => array(
 5074+ * $wgPoolCounterConf = array( 'ArticleView' => array(
50755075 * 'class' => 'PoolCounter_Client',
 5076+ * 'timeout' => 15, // wait timeout in seconds
 5077+ * 'workers' => 5, // maximum number of active threads in each pool
 5078+ * 'maxqueue' => 50, // maximum number of total threads in each pool
50765079 * ... any extension-specific options...
50775080 * );
50785081 */
Index: trunk/extensions/PoolCounter/PoolCounterClient.php
@@ -31,7 +31,7 @@
3232
3333 /**
3434 * Sample pool configuration:
35 - * $wgPoolCounterConf = array( 'PoolWorkArticleView' => array(
 35+ * $wgPoolCounterConf = array( 'ArticleView' => array(
3636 * 'class' => 'PoolCounter_Client',
3737 * 'timeout' => 15, // wait timeout in seconds
3838 * 'workers' => 5, // maximum number of active threads in each pool

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71805Make a bunch of incompatible changes to the PoolCounter....platonides20:57, 27 August 2010

Status & tagging log