r73043 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73042‎ | r73043 | r73044 >
Date:01:50, 15 September 2010
Author:awjrichards
Status:deferred
Tags:
Comment:
Updated params passed to wfRunHooks to explicitly declare references where necessary for compatibility with PHP 5.3
Modified paths:
  • /trunk/extensions/DonationInterface/payflowpro_gateway/extras/custom_filters/custom_filters.body.php (modified) (history)
  • /trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/payflowpro_gateway/payflowpro_gateway.body.php
@@ -113,24 +113,24 @@
114114 $this->fnPayflowDisplayForm( $data, $error );
115115 } else { // The submitted form data is valid, so process it
116116 // allow any external validators to have their way with the data
117 - wfRunHooks( 'PayflowGatewayValidate', array( $this, $data ));
 117+ wfRunHooks( 'PayflowGatewayValidate', array( &$this, &$data ));
118118
119119 // if the transaction was flagged for review
120120 if ( $this->action == 'review' ) {
121121 // expose a hook for external handling of trxns flagged for review
122 - wfRunHooks( 'PayflowGatewayReview', array( $this, $data ));
 122+ wfRunHooks( 'PayflowGatewayReview', array( &$this, &$data ));
123123 }
124124
125125 // if the transaction was flagged to be 'challenged'
126126 if ( $this->action == 'challenge' ) {
127127 // expose a hook for external handling of trxns flagged for challenge (eg captcha)
128 - wfRunHooks( 'PayflowGatewayChallenge', array( $this, $data ));
 128+ wfRunHooks( 'PayflowGatewayChallenge', array( &$this, &$data ));
129129 }
130130
131131 // if the transaction was flagged for rejection
132132 if ( $this->action == 'reject' ) {
133133 // expose a hook for external handling of trxns flagged for rejection
134 - wfRunHooks( 'PayflowGatewayReject', array( $this, $data ));
 134+ wfRunHooks( 'PayflowGatewayReject', array( &$this, &$data ));
135135
136136 $this->fnPayflowDisplayDeclinedResults( '' );
137137 $this->fnPayflowUnsetEditToken();
@@ -139,13 +139,13 @@
140140 // if the transaction was flagged for processing
141141 if ( $this->action == 'process' ) {
142142 // expose a hook for external handling of trxns ready for processing
143 - wfRunHooks( 'PayflowGatewayProcess', array( $this, $data ));
 143+ wfRunHooks( 'PayflowGatewayProcess', array( &$this, &$data ));
144144 $this->fnPayflowProcessTransaction( $data, $payflow_data );
145145 $this->fnPayflowUnsetEditToken();
146146 }
147147
148148 // expose a hook for any post processing
149 - wfRunHooks( 'PayflowGatewayPostProcess', array( $this, $data ));
 149+ wfRunHooks( 'PayflowGatewayPostProcess', array( &$this, &$data ));
150150 }
151151 } else {
152152 //Display form for the first time
Index: trunk/extensions/DonationInterface/payflowpro_gateway/extras/custom_filters/custom_filters.body.php
@@ -71,7 +71,7 @@
7272 */
7373 public function validate() {
7474 // expose a hook for custom filters
75 - wfRunHooks( 'PayflowGatewayCustomFilter', array( $this ));
 75+ wfRunHooks( 'PayflowGatewayCustomFilter', array( &$this ));
7676 $this->gateway_object->action = $this->determineAction();
7777
7878 $log_msg = '"' . $this->gateway_object->action . "\"\t\"" . $this->risk_score . "\"";

Status & tagging log