r73042 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r73041‎ | r73042 | r73043 >
Date:01:48, 15 September 2010
Author:tparscal
Status:resolved (Comments)
Tags:
Comment:
Removed remnant of this being a mediaWiki module.
Modified paths:
  • /trunk/phase3/resources/jquery/jquery.client.js (modified) (history)

Diff [purge]

Index: trunk/phase3/resources/jquery/jquery.client.js
——@@ -2,11 +2,7 @@
33 * User-agent detection
44 */
55
6 -( function( $, mw ) {
7 -
8 -/* Extension */
9 -
10 -$.client = {
 6+jQuery.client = {
117 /**
128 * Returns an object containing information about the browser
139 *

Comments

#Comment by Catrope (talk | contribs)   14:55, 1 October 2010

You still need to wrap this in a closure because $ is used in the code.

#Comment by Trevor Parscal (WMF) (talk | contribs)   18:03, 1 October 2010

That would have been true, but it's not as of r73050.

#Comment by Catrope (talk | contribs)   18:05, 1 October 2010

Yup, as of that rev it uses jQuery throughout.

Status & tagging log