r73033 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73032‎ | r73033 | r73034 >
Date:01:00, 15 September 2010
Author:purodha
Status:ok
Tags:
Comment:
Revert r73031 (untested)
Modified paths:
  • /trunk/extensions/Wikidata/OmegaWiki/Editor.php (modified) (history)
  • /trunk/extensions/Wikidata/Wikidata.i18n.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Wikidata/OmegaWiki/Editor.php
@@ -705,7 +705,7 @@
706706 $headerRows = getStructureAsTableHeaderRows( $visibleStructure, $columnOffset, $idPath );
707707
708708 if ( $this->allowRemove )
709 - $headerRows[0] = '<th class="remove" rowspan="' . count( $headerRows ) . '"><img src="' . $wgStylePath . '/amethyst/delete.png" title="' . wfMsgSc( "RemoveHint" ) . '" alt="' . wfMsgSc( "ow_editor_remove" ) . '"/></th>' . $headerRows[0];
 709+ $headerRows[0] = '<th class="remove" rowspan="' . count( $headerRows ) . '"><img src="' . $wgStylePath . '/amethyst/delete.png" title="' . wfMsgSc( "RemoveHint" ) . '" alt="' . wfMsgSc( "Remove" ) . '"/></th>' . $headerRows[0];
710710
711711 if ( $this->repeatInput )
712712 $headerRows[0] .= '<th class="add" rowspan="' . count( $headerRows ) . '">Input rows</th>';
@@ -806,7 +806,7 @@
807807
808808 # + is add new Fo o(but grep this file for Add.png for more)
809809 if ( $allowRemove ) {
810 - $result .= '<td class="add"><img src="' . $wgScriptPath . '/extensions/Wikidata/Images/Add.png" title="' . wfMsgSc( "ow_AddHint" ) . '" alt="' . wfMsgSc( "ow_editor_add" ) . '" onclick="addEmptyRow(this.parentNode.parentNode.id);"/></td>' . EOL;
 810+ $result .= '<td class="add"><img src="' . $wgScriptPath . '/extensions/Wikidata/Images/Add.png" title="' . wfMsgSc( "AddHint" ) . '" alt="Add" onclick="addEmptyRow(this.parentNode.parentNode.id);"/></td>' . EOL;
811811 }
812812
813813 $result .= $this->getStructureAsAddCells( $idPath, $this );
@@ -1951,7 +1951,7 @@
19521952
19531953 # For which class is this add?
19541954 $result .= '<li>' .
1955 - '<h' . $this->headerLevel . '><span id="collapse-' . $recordId . '" class="toggle ' . addCollapsablePrefixToClass( $class ) . '" onclick="toggle(this, event);">' . $this->getExpansionPrefix( $idPath->getClass(), $idPath->getId() ) . ' <img src="' . $wgScriptPath . '/extensions/Wikidata/Images/Add.png" title="' . wfMsgSc( 'ow_AddHintList' ) . '" alt="' . wfMsgSc( "ow_editor_add" ) . '" onclick="addEmptyRow(this.parentNode.parentNode.id);"/>' . $this->captionEditor->add( $idPath ) . '</span></h' . $this->headerLevel . '>' . EOL;
 1955+ '<h' . $this->headerLevel . '><span id="collapse-' . $recordId . '" class="toggle ' . addCollapsablePrefixToClass( $class ) . '" onclick="toggle(this, event);">' . $this->getExpansionPrefix( $idPath->getClass(), $idPath->getId() ) . ' <img src="' . $wgScriptPath . '/extensions/Wikidata/Images/Add.png" title="Enter new list item to add" alt="Add" onclick="addEmptyRow(this.parentNode.parentNode.id);"/>' . $this->captionEditor->add( $idPath ) . '</span></h' . $this->headerLevel . '>' . EOL;
19561956 $idPath->popAttribute();
19571957
19581958 $idPath->pushAttribute( $valueAttribute );
Index: trunk/extensions/Wikidata/Wikidata.i18n.php
@@ -96,8 +96,6 @@
9797 'ow_noedit' => 'You are not permitted to edit pages in the dataset "$1".
9898 Please see [[{{MediaWiki:Ow editing policy url}}|our editing policy]].',
9999 'ow_editing_policy_url' => 'Project:Permission policy',
100 - 'ow_editor_add' => 'Add',
101 - 'ow_editor_remove' => 'Remove',
102100 'ow_uipref_datasets' => 'Default view:',
103101 'ow_uiprefs' => 'Wikidata',
104102 'ow_none_selected' => 'None selected',
@@ -148,7 +146,6 @@
149147 Please check the web address.',
150148
151149 'ow_AddHint' => 'Enter new rows to add',
152 - 'ow_AddHintList' => 'Enter new list item to add',
153150 'ow_AlternativeDefinition' => 'Alternative definition',
154151 'ow_AlternativeDefinitions' => 'Alternative definitions',
155152 'ow_Annotation' => 'Annotation',
@@ -311,8 +308,6 @@
312309 'ow_searchnoresult' => "Don't translate the word ''Expression'' in ''<nowiki>[[Expression:$1]]</nowiki>''",
313310 'ow_save' => '{{Identical|Save}}',
314311 'ow_history' => '{{Identical|History}}',
315 - 'ow_editor_add' => 'Used in edit pages as <code>alt=</code> attribute of the "add" button image.',
316 - 'ow_editor_remove' => 'Used in edit pages as <code>alt=</code> attribute of the "remove" button image.',
317312 'ow_none_selected' => '{{Identical|None selected}}',
318313 'transaction' => "A 'transaction' is a database transaction: a set of database operations considered as a whole.",
319314 'ow_transaction_count' => '{{Identical|Count}}',
@@ -326,7 +321,6 @@
327322 'ow_dm_OK' => '{{Identical|OK}}',
328323 'ow_dm_not_present' => 'Used on [http://www.omegawiki.org/index.php?title=Special:ConceptMapping Special:ConceptMapping]',
329324 'ow_AddHint' => 'Hint that shows up when the mouse hovers the plus sign in table rows (such as Synonyms and Translations) while editing',
330 - 'ow_AddHintList' => 'Hint that shows up when the mouse hovers the plus sign in list rows (such as Annotations) while editing',
331325 'ow_Annotation' => '{{Identical|Annotation}}',
332326 'ow_ClassAttributeAttribute' => '{{Identical|Attribute}}',
333327 'ow_ClassAttributeType' => '{{Identical|Type}}',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r73031Fix some unlocalized strings.purodha00:57, 15 September 2010

Status & tagging log