r73022 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73021‎ | r73022 | r73023 >
Date:21:25, 14 September 2010
Author:dale
Status:deferred
Tags:
Comment:
fixed missing + in string
other minor formating updates
Modified paths:
  • /branches/MwEmbedStandAlone/modules/Sequencer/loader.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerAddByUrl.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerServer.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/Sequencer/loader.js
@@ -63,8 +63,7 @@
6464 'mw.SequencerConfig'
6565 ],
6666 [
67 - '$j.contextMenu',
68 -
 67+ '$j.contextMenu',
6968 'mw.SequencerServer',
7069 'mw.SequencerAddByUrl',
7170 'mw.SequencerAddMedia',
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerServer.js
@@ -291,14 +291,15 @@
292292 pageText = _this.getBaseFileDescription()
293293 }
294294 var request = {
295 - 'action':'edit',
 295+ 'action': 'edit',
296296 'token' : token,
297297 'title' : 'File:' + _this.getVideoFileName(),
298298 'summary' : 'Automated sequence description page for published sequence: ' + _this.getTitleKey(),
299299 'text' : pageText
300300 };
301 - mw.getJSON( _this.getApiUrl(), request, function(data){
302 - if( data && data.edit && data.edit.result == "Success"){
 301+
 302+ mw.getJSON( _this.getApiUrl(), request, function( data ){
 303+ if( data && data.edit && data.edit.result == "Success" ){
303304 callback( true );
304305 } else {
305306 callback( false );
@@ -307,22 +308,24 @@
308309 })
309310 },
310311
311 - getBaseFileDescription: function(){
312 - var _this = this;
313 - return 'Published sequence for [['+ _this.getTitleKey() + ']]';
 312+ getBaseFileDescription: function(){
 313+ return 'Published sequence for [[' + this.getTitleKey() + ']]';
314314 },
315315
316316 getCommonsDescriptionText: function(){
317317 var _this = this;
318318
319 - var descText = '<!-- ' +
320 - "Note: this is an automated file description for a published video sequence. \n"
321 - "Changes to this wikitext will be overwiten. Please add metadata and categories to\n" +
322 - _this.getTitleKey() + " instead --> \n" +
 319+ var descText = "<!-- " +
 320+ "Note: this is an automated file description for a published video sequence. \n" +
 321+ "Changes to this wikitext will be overwiten. Please add metadata and categories to\n" +
 322+ _this.getTitleKey() +
 323+ " instead --> \n" +
323324 "{{Information\n" +
324325 "|Description=" + _this.getBaseFileDescription() + "\n" +
325326 "|Source= Sequence Sources assets include:\n";
326327
 328+
 329+
327330 // loop over every asset:
328331 this.sequencer.getSmil().getBody().getRefElementsRecurse(null, 0, function( $node ){
329332 var $apiKeyParam = $node.children("param[name='apiTitleKey']");
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerAddByUrl.js
@@ -121,6 +121,6 @@
122122 // try directly adding the asset
123123 }
124124 }
125 -}
 125+};
126126
127127 } )( window.mw );
\ No newline at end of file

Status & tagging log