r73014 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73013‎ | r73014 | r73015 >
Date:20:17, 14 September 2010
Author:dale
Status:deferred
Tags:
Comment:
bumped version minor and minor space formating
Modified paths:
  • /branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.Sequencer.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerServer.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/Sequencer/remotes/mw.MediaWikiRemoteSequencer.js (modified) (history)
  • /branches/MwEmbedStandAlone/modules/SmilPlayer/mw.EmbedPlayerSmil.js (modified) (history)
  • /branches/MwEmbedStandAlone/remotes/mediaWiki.js (modified) (history)

Diff [purge]

Index: branches/MwEmbedStandAlone/modules/SmilPlayer/mw.EmbedPlayerSmil.js
@@ -102,6 +102,7 @@
103103 } );
104104 });
105105 },
 106+
106107 /**
107108 * Issue a seeking request.
108109 *
Index: branches/MwEmbedStandAlone/modules/EmbedPlayer/skins/mw.PlayerControlBuilder.js
@@ -972,6 +972,7 @@
973973 // Show the big play button:
974974 embedPlayer.$interface.find( '.play-btn-large' ).fadeIn( 'slow' );
975975
 976+
976977 $j(embedPlayer).trigger( 'closeMenuOverlay' );
977978
978979 return false; // onclick action return false
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.Sequencer.js
@@ -7,6 +7,7 @@
88 /*
99 * Setup the sequencer jQuery binding:
1010 */
 11+
1112 ( function( $ ) {
1213 $.fn.sequencer = function( options ) {
1314 // Debugger
Index: branches/MwEmbedStandAlone/modules/Sequencer/mw.SequencerServer.js
@@ -283,7 +283,7 @@
284284 updateSequenceFileDescription: function( callback ){
285285 var _this = this;
286286 mw.getToken( _this.getApiUrl(), 'File:' + _this.getVideoFileName(), function( token ){
287 - var pageText = ''
 287+ var pageText = '';
288288 // Check if we should use commons asset description template:
289289 if( mw.parseUri( _this.getApiUrl() ).host == 'commons.wikimedia.org' ){
290290 pageText = _this.getCommonsDescriptionText()
@@ -301,26 +301,27 @@
302302 if( data && data.edit && data.edit.result == "Success"){
303303 callback( true );
304304 } else {
305 - callback( false )
 305+ callback( false );
306306 }
307307 });
308308 })
309309 },
 310+
310311 getBaseFileDescription: function(){
311312 var _this = this;
312313 return 'Published sequence for [['+ _this.getTitleKey() + ']]';
313314 },
 315+
314316 getCommonsDescriptionText: function(){
315317 var _this = this;
316318
317319 var descText = '<!-- ' +
318320 "Note: this is an automated file description for a published video sequence. \n"
319321 "Changes to this wikitext will be overwiten. Please add metadata and categories to\n" +
320 - _this.getTitleKey() + " instead --> \n";
321 -
322 - descText += "{{Information\n" +
323 - "|Description=" + _this.getBaseFileDescription() + "\n" +
324 - "|Source= Sequence Sources assets include:\n";
 322+ _this.getTitleKey() + " instead --> \n" +
 323+ "{{Information\n" +
 324+ "|Description=" + _this.getBaseFileDescription() + "\n" +
 325+ "|Source= Sequence Sources assets include:\n";
325326
326327 // loop over every asset:
327328 this.sequencer.getSmil().getBody().getRefElementsRecurse(null, 0, function( $node ){
@@ -346,6 +347,7 @@
347348
348349 // Add Published Sequence category ( for now )
349350 descText += "\n[[Category:Published Sequence]]\n";
 351+
350352 return descText;
351353 },
352354
@@ -376,7 +378,7 @@
377379 */
378380 getSequenceEditUrl: function( titleKey ){
379381 var viewUrl = this.getSequenceViewUrl( titleKey );
380 - return mw.replaceUrlParams(viewUrl, {'action':'edit'})
 382+ return mw.replaceUrlParams(viewUrl, {'action':'edit'});
381383 },
382384
383385 /**
@@ -392,7 +394,7 @@
393395 var _this = this;
394396 mw.getToken( this.getApiUrl(), 'File:' + this.getVideoFileName(), function( saveToken ){
395397 // xxx Get the latest save comment
396 - _this.getSaveSummary(function( saveSummary ){
 398+ _this.getSaveSummary( function( saveSummary ){
397399 var request = {
398400 'token' : saveToken,
399401 'action' : 'upload',
@@ -410,7 +412,7 @@
411413 sequencePublishUploadDone: function(){
412414 this.sequencePublished = true;
413415 }
414 - }
 416+ };
415417
416418
417419 } )( window.mw );
\ No newline at end of file
Index: branches/MwEmbedStandAlone/modules/Sequencer/remotes/mw.MediaWikiRemoteSequencer.js
@@ -316,7 +316,7 @@
317317 .css( {'cursor': 'pointer', 'font-size':'x-small' })
318318 );
319319 // load the sequence editor with the sequencerContainer target
320 - mw.load( 'Sequencer', function(){
 320+ mw.load( 'Sequencer', function(){
321321 $j('#sequencerContainer').sequencer( _this.getSequencerConfig() );
322322 });
323323 },
@@ -496,7 +496,7 @@
497497 .css( {'width':'200px', 'margin':'auto'})
498498 )
499499 )
500 - mw.load( 'Sequencer', function(){
 500+ mw.load( 'Sequencer', function(){
501501 // Send a jquery ui style destroy command ( in case the editor is re-invoked )
502502 $j('#edit_sequence_container').sequencer( 'destroy');
503503 $j('#edit_sequence_container').sequencer( _this.getSequencerConfig() );
@@ -544,21 +544,6 @@
545545 return mw.absoluteUrl( wgScript.replace('index.php', 'api.php') );
546546 }
547547
548 - // Check page type
 548+};
549549
550 - // "view" page
551 -
552 - // set page content to "loading"
553 - // get wikitext of page via api
554 - // grab xml
555 - // update page with sequence and
556 -
557 -
558 - //"edit" page
559 - // grab textbox text,
560 - // set page to loading
561 - // display sequence editor in "body" with -> full-screen link
562 -}; //Setup the remote configuration
563 -
564 -
565550 } )( window.mw );
\ No newline at end of file
Index: branches/MwEmbedStandAlone/remotes/mediaWiki.js
@@ -4,7 +4,7 @@
55 */
66 var urlparts = getRemoteEmbedPath();
77 var mwEmbedHostPath = urlparts[0];
8 -var mwRemoteVersion = 'r144';
 8+var mwRemoteVersion = 'r145';
99 var mwUseScriptLoader = true;
1010
1111 // Log the mwRemote version makes it easy to debug cache issues
@@ -35,8 +35,9 @@
3636 mwUseScriptLoader = false;
3737 }
3838
39 -//mwReqParam['debug'] =false;
 39+//mwReqParam['debug'] = false;
4040 //mwUseScriptLoader = true;
 41+//mwRemoteVersion = Math.random();
4142
4243 // Setup up some globals to wrap mwEmbed mw.ready and mw.setConfig functions
4344

Status & tagging log