r73001 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r73000‎ | r73001 | r73002 >
Date:17:56, 14 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
fixing double-escaping per comment at r72769
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialCentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialCentralNotice.php
@@ -510,7 +510,7 @@
511511 $htmlOut .= Xml::closeElement( 'tr' );
512512 // Countries
513513 $htmlOut .= Xml::openElement( 'tr' );
514 - $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsgHtml( 'centralnotice-geotargeted' ), 'geotargeted' ) );
 514+ $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsg( 'centralnotice-geotargeted' ), 'geotargeted' ) );
515515 $htmlOut .= Xml::tags( 'td', array(), Xml::check( 'geotargeted', false, wfArrayMerge( $readonly, array( 'value' => 1, 'id' => 'geotargeted' ) ) ) );
516516 $htmlOut .= Xml::closeElement( 'tr' );
517517 $htmlOut .= Xml::openElement( 'tr', array( 'id'=>'geoMultiSelector', 'style'=>'display:none;' ) );
@@ -829,7 +829,7 @@
830830 $htmlOut .= Xml::closeElement( 'tr' );
831831 // Countries
832832 $htmlOut .= Xml::openElement( 'tr' );
833 - $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsgHtml( 'centralnotice-geotargeted' ), 'geotargeted' ) );
 833+ $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsg( 'centralnotice-geotargeted' ), 'geotargeted' ) );
834834 $htmlOut .= Xml::tags( 'td', array(), Xml::check( 'geotargeted', $isGeotargeted, wfArrayMerge( $readonly, array( 'value' => $row->not_name, 'id' => 'geotargeted' ) ) ) );
835835 $htmlOut .= Xml::closeElement( 'tr' );
836836 if ( $isGeotargeted ) {
@@ -842,23 +842,23 @@
843843 $htmlOut .= Xml::closeElement( 'tr' );
844844 // Enabled
845845 $htmlOut .= Xml::openElement( 'tr' );
846 - $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsgHtml( 'centralnotice-enabled' ), 'enabled' ) );
 846+ $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsg( 'centralnotice-enabled' ), 'enabled' ) );
847847 $htmlOut .= Xml::tags( 'td', array(), Xml::check( 'enabled', $isEnabled, wfArrayMerge( $readonly, array( 'value' => $row->not_name, 'id' => 'enabled' ) ) ) );
848848 $htmlOut .= Xml::closeElement( 'tr' );
849849 // Preferred
850850 $htmlOut .= Xml::openElement( 'tr' );
851 - $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsgHtml( 'centralnotice-preferred' ), 'preferred' ) );
 851+ $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsg( 'centralnotice-preferred' ), 'preferred' ) );
852852 $htmlOut .= Xml::tags( 'td', array(), Xml::check( 'preferred', $isPreferred, wfArrayMerge( $readonly, array( 'value' => $row->not_name, 'id' => 'preferred' ) ) ) );
853853 $htmlOut .= Xml::closeElement( 'tr' );
854854 // Locked
855855 $htmlOut .= Xml::openElement( 'tr' );
856 - $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsgHtml( 'centralnotice-locked' ), 'locked' ) );
 856+ $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsg( 'centralnotice-locked' ), 'locked' ) );
857857 $htmlOut .= Xml::tags( 'td', array(), Xml::check( 'locked', $isLocked, wfArrayMerge( $readonly, array( 'value' => $row->not_name, 'id' => 'locked' ) ) ) );
858858 $htmlOut .= Xml::closeElement( 'tr' );
859859 if ( $this->editable ) {
860860 // Locked
861861 $htmlOut .= Xml::openElement( 'tr' );
862 - $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsgHtml( 'centralnotice-remove' ), 'remove' ) );
 862+ $htmlOut .= Xml::tags( 'td', array(), Xml::label( wfMsg( 'centralnotice-remove' ), 'remove' ) );
863863 $htmlOut .= Xml::tags( 'td', array(), Xml::check( 'remove', false, array( 'value' => $row->not_name, 'id' => 'remove' ) ) );
864864 $htmlOut .= Xml::closeElement( 'tr' );
865865 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72769localizing new interface components from r72765kaldari23:44, 10 September 2010

Status & tagging log