r72998 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72997‎ | r72998 | r72999 >
Date:17:42, 14 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
fixing incomplete var rename from r72698 (follow-up to r72997)
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)
  • /trunk/extensions/CentralNotice/newCentralNotice.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/newCentralNotice.js
@@ -18,10 +18,8 @@
1919 },
2020 'fn': {
2121 'loadBanner': function( bannerName ) {
22 - // get the requested banner from /centralnotice/banners/<bannername>/<wgUserLanguage>.js
 22+ // get the requested banner
2323 var bannerPage = 'Special:BannerLoader?banner='+bannerName+'&userlang='+wgContentLanguage+'&sitename='+wgNoticeProject;
24 - //centralized version:
25 - //var bannerURL = 'http://meta.wikimedia.org/wiki/'+bannerPage;
2624 var bannerURL = wgArticlePath.replace( '$1', bannerPage );
2725 var request = $.ajax( {
2826 url: bannerURL,
@@ -39,9 +37,7 @@
4038 // http://geoiplookup.wikimedia.org/
4139 var geoLocation = 'US'; // Hard-coding for now
4240 var bannerListPage = 'Special:BannerListLoader?language='+wgContentLanguage+'&project='+wgNoticeProject+'&location='+geoLocation;
43 - //centralized version:
44 - //var bannerListURL = 'http://meta.wikimedia.org/wiki/'+bannerListPage;
45 - var bannerListURL = wgArticlePath.replace( '$1', bannerListPage );
 41+ bannerListURL = wgArticlePath.replace( '$1', bannerListPage );
4642 }
4743 var request = $.ajax( {
4844 url: bannerListURL,
Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -68,7 +68,7 @@
6969 var bannerListURL;
7070 var geoLocation = Geo.country; // pull the geo info
7171 var bannerListPage = 'Special:BannerListLoader?language='+wgContentLanguage+'&project='+wgNoticeProject+'&location='+geoLocation;
72 - var bannerListURL = wgArticlePath.replace( '$1', bannerListPage );
 72+ bannerListURL = wgArticlePath.replace( '$1', bannerListPage );
7373 var request = $.ajax( {
7474 url: bannerListURL,
7575 dataType: 'json',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72698building correct bannerlistloader URLkaldari01:32, 10 September 2010
r72997fixing incomplete var rename from r72698kaldari17:36, 14 September 2010

Status & tagging log