r72997 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72996‎ | r72997 | r72998 >
Date:17:36, 14 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
fixing incomplete var rename from r72698
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialBannerController.php (modified) (history)
  • /trunk/extensions/CentralNotice/newCentralNotice.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/newCentralNotice.js
@@ -32,9 +32,9 @@
3333 });
3434 },
3535 'loadBannerList': function( timestamp ) {
36 - var listURL;
 36+ var bannerListURL;
3737 if ( timestamp ) {
38 - listURL = "TBD"
 38+ bannerListURL = "TBD"
3939 } else {
4040 // http://geoiplookup.wikimedia.org/
4141 var geoLocation = 'US'; // Hard-coding for now
Index: trunk/extensions/CentralNotice/SpecialBannerController.php
@@ -65,7 +65,7 @@
6666 });
6767 },
6868 'loadBannerList': function( timestamp ) {
69 - var listURL;
 69+ var bannerListURL;
7070 var geoLocation = Geo.country; // pull the geo info
7171 var bannerListPage = 'Special:BannerListLoader?language='+wgContentLanguage+'&project='+wgNoticeProject+'&location='+geoLocation;
7272 var bannerListURL = wgArticlePath.replace( '$1', bannerListPage );

Follow-up revisions

RevisionCommit summaryAuthorDate
r72998fixing incomplete var rename from r72698 (follow-up to r72997)kaldari17:42, 14 September 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72698building correct bannerlistloader URLkaldari01:32, 10 September 2010

Status & tagging log