r72869 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72868‎ | r72869 | r72870 >
Date:15:59, 12 September 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Move input to last to have a logical order
Modified paths:
  • /trunk/extensions/Translate/SpecialTranslationStats.php (modified) (history)
  • /trunk/extensions/Translate/utils/HTMLJsSelectToInputField.php (modified) (history)
  • /trunk/extensions/Translate/utils/JsSelectToInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/SpecialTranslationStats.php
@@ -243,8 +243,8 @@
244244
245245 return
246246 '<tr><td>' . $this->eLabel( $name ) . '</td><td>' .
 247+ $select->getHtmlAndPrepareJs() . '<br />' .
247248 Xml::input( $name, 20, $value, array( 'id' => $name ) ) .
248 - $select->getHtmlAndPrepareJs() .
249249 '</td></tr>' . "\n";
250250 }
251251
@@ -289,8 +289,8 @@
290290
291291 return
292292 '<tr><td>' . $this->eLabel( $name ) . '</td><td>' .
 293+ $select->getHtmlAndPrepareJs() . '<br />' .
293294 Xml::input( $name, 20, $value, array( 'id' => $name ) ) .
294 - $select->getHtmlAndPrepareJs() .
295295 '</td></tr>' . "\n";
296296 }
297297
Index: trunk/extensions/Translate/utils/JsSelectToInput.php
@@ -82,8 +82,8 @@
8383 }
8484
8585 self::injectJs();
86 - $html = $this->getButton( $this->msg, $this->sourceId, $this->targetId );
87 - $html .= $this->select->getHtml();
 86+ $html = $this->select->getHtml();
 87+ $html .= $this->getButton( $this->msg, $this->sourceId, $this->targetId );
8888
8989 return $html;
9090 }
Index: trunk/extensions/Translate/utils/HTMLJsSelectToInputField.php
@@ -15,7 +15,7 @@
1616 $input = parent::getInputHTML( $value );
1717
1818 if ( isset( $this->mParams['select'] ) ) {
19 - $input .= ' ' . $this->mParams['select']->getHtmlAndPrepareJs();
 19+ $input = $this->mParams['select']->getHtmlAndPrepareJs() . '<br />' . $input;
2020 }
2121
2222 return $input;

Status & tagging log