r72864 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72863‎ | r72864 | r72865 >
Date:15:15, 12 September 2010
Author:catrope
Status:ok
Tags:
Comment:
(bug 24987) Special:ListUsers does not take external groups into account. Patch by Mathias Ertl
Modified paths:
  • /trunk/phase3/CREDITS (modified) (history)
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialListusers.php (modified) (history)

Diff [purge]

Index: trunk/phase3/CREDITS
@@ -102,6 +102,7 @@
103103 * Marcin Cieślak
104104 * Marcus Buck
105105 * Marooned
 106+* Mathias Ertl
106107 * Matthew Britton
107108 * mati
108109 * Max Sikström
Index: trunk/phase3/includes/specials/SpecialListusers.php
@@ -125,13 +125,12 @@
126126 $userPage = Title::makeTitle( NS_USER, $row->user_name );
127127 $name = $this->getSkin()->link( $userPage, htmlspecialchars( $userPage->getText() ) );
128128
129 - if( $row->numgroups > 1 || ( $this->requestedGroup && $row->numgroups == 1 ) ) {
 129+ $groups_list = self::getGroups( $row->user_id );
 130+ if( count( $groups_list ) > 0 ) {
130131 $list = array();
131 - foreach( self::getGroups( $row->user_id ) as $group )
 132+ foreach( $groups_list as $group )
132133 $list[] = self::buildGroupLink( $group );
133134 $groups = $wgLang->commaList( $list );
134 - } elseif( $row->numgroups == 1 ) {
135 - $groups = self::buildGroupLink( $row->singlegroup );
136135 } else {
137136 $groups = '';
138137 }
Index: trunk/phase3/RELEASE-NOTES
@@ -315,6 +315,7 @@
316316 * (bug 6204) TOC not properly rendered when using $wgMaxTocLevel
317317 * (bug 24977) The accesskey in history page now lead directly to the diff
318318 instead of alterning focus between the two buttons.
 319+* (bug 24987) Special:ListUsers does not take external groups into account
319320
320321 === API changes in 1.17 ===
321322 * (bug 22738) Allow filtering by action type on query=logevent.

Status & tagging log