r72768 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72767‎ | r72768 | r72769 >
Date:23:34, 10 September 2010
Author:kaldari
Status:ok
Tags:
Comment:
fixing some bugs in r72765
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialCentralNotice.php (modified) (history)
  • /trunk/extensions/CentralNotice/centralnotice.js (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialCentralNotice.php
@@ -509,7 +509,7 @@
510510 // Countries
511511 $htmlOut .= Xml::openElement( 'tr' );
512512 $htmlOut .= Xml::tags( 'td', array(), Xml::label( 'Geotargeted', 'geotargeted' ) );
513 - $htmlOut .= Xml::tags( 'td', array(), Xml::check( 'geotargeted', false, wfArrayMerge( $readonly, array( 'value' => 0, 'id' => 'geotargeted' ) ) ) );
 513+ $htmlOut .= Xml::tags( 'td', array(), Xml::check( 'geotargeted', false, wfArrayMerge( $readonly, array( 'value' => 1, 'id' => 'geotargeted' ) ) ) );
514514 $htmlOut .= Xml::closeElement( 'tr' );
515515 $htmlOut .= Xml::openElement( 'tr', array( 'id'=>'geoMultiSelector' ) );
516516 $htmlOut .= Xml::tags( 'td', array( 'valign' => 'top' ), 'Countries' );
Index: trunk/extensions/CentralNotice/centralnotice.js
@@ -48,9 +48,9 @@
4949 $(document).ready(function() {
5050 $("#geotargeted").click(function () {
5151 if ($('#geotargeted:checked').val() !== undefined) {
52 - $("#geoMultiSelector").show('slow');
 52+ $("#geoMultiSelector").fadeIn('fast');
5353 } else {
54 - $("#geoMultiSelector").hide('slow');
 54+ $("#geoMultiSelector").fadeOut('fast');
5555 }
5656 });
5757 });

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r72765beginning to add geotargetting interfacekaldari23:07, 10 September 2010

Status & tagging log