r72755 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72754‎ | r72755 | r72756 >
Date:20:55, 10 September 2010
Author:tparscal
Status:ok
Tags:
Comment:
Adjusted comments
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
@@ -2313,10 +2313,11 @@
23142314 // Statup - this will immediately load jquery and mediawiki modules
23152315 $scripts = self::makeResourceLoaderLink( $sk, 'startup', 'scripts' );
23162316
2317 - // Configuration
 2317+ // Configuration -- this could be merged together with the load and go, but makeGlobalVariablesScript returns a
 2318+ // whole script tag -- grumble grumble
23182319 $scripts .= Skin::makeGlobalVariablesScript( $sk->getSkinName() ) . "\n";
23192320
2320 - // Support individual script requests in debug mode
 2321+ // Script and Messages "only"
23212322 if ( $wgRequest->getBool( 'debug' ) && $wgRequest->getVal( 'debug' ) !== 'false' ) {
23222323 // Scripts
23232324 foreach ( $this->getModuleScripts() as $name ) {
@@ -2336,8 +2337,9 @@
23372338 $scripts .= self::makeResourceLoaderLink( $sk, $this->getModuleMessages(), 'messages' );
23382339 }
23392340 }
 2341+
 2342+ // Modules - let the client calculate dependencies and batch requests as it likes
23402343 if ( $this->getModules() ) {
2341 - // Modules - let the client calculate dependencies and batch requests as it likes
23422344 $modules = FormatJson::encode( $this->getModules() );
23432345 $scripts .= Html::inlineScript(
23442346 "if ( mediaWiki !== undefined ) { mediaWiki.loader.load( {$modules} ); mediaWiki.loader.go(); }"

Status & tagging log