r72747 MediaWiki - Code Review archive
Repository:
MediaWiki
Revision:
<
r72746
|
r72747
|
r72748
>
Date:
20:31, 10 September 2010
Author:
platonides
Status:
ok
Tags:
Comment:
(
Bug 25138
) ApiUndelete begins a transaction, but does not commit.
The UI doesn't use a transaction either, although it seems appropiate.
The begin() should be moved into PageArchive::undelete()
Modified paths:
/trunk/phase3/includes/api/ApiUndelete.php
(modified) (
history
)
Diff
[
purge
]
Index: trunk/phase3/includes/api/ApiUndelete.php
—
—
@@ -69,8 +69,6 @@
70
70
}
71
71
72
72
$pa = new PageArchive( $titleObj );
73
- $dbw = wfGetDB( DB_MASTER );
74
- $dbw->begin();
75
73
$retval = $pa->undelete( ( isset( $params['timestamps'] ) ? $params['timestamps'] : array() ), $params['reason'] );
76
74
if ( !is_array( $retval ) ) {
77
75
$this->dieUsageMsg( array( 'cannotundelete' ) );
Status & tagging log
15:37, 27 September 2010
Catrope
(
talk
|
contribs
)
changed the
status
of r72747
[
removed:
new
added:
ok]