r72741 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r72740‎ | r72741 | r72742 >
Date:20:06, 10 September 2010
Author:laner
Status:deferred
Tags:
Comment:
Fixed bad references to $ldapconn; they should have been $this->ldapconn.
Modified paths:
  • /trunk/extensions/LdapAuthentication/LdapAuthentication.php (modified) (history)

Diff [purge]

Index: trunk/extensions/LdapAuthentication/LdapAuthentication.php
@@ -1487,8 +1487,8 @@
14881488 if ( $dn != "*" ) {
14891489 $PGfilter = "(&(distinguishedName=$value)(objectclass=user))";
14901490 $this->printDebug( "User Filter: $PGfilter", SENSITIVE );
1491 - $PGinfo = @ldap_search( $ldapconn, $base, $PGfilter );
1492 - $PGentries = @ldap_get_entries( $ldapconn, $PGinfo );
 1491+ $PGinfo = @ldap_search( $this->ldapconn, $base, $PGfilter );
 1492+ $PGentries = @ldap_get_entries( $this->ldapconn, $PGinfo );
14931493 if ( $PGentries ) {
14941494 $Usid = $PGentries[0]['objectsid'][0];
14951495 $PGrid = $PGentries[0]['primarygroupid'][0];
@@ -1510,8 +1510,8 @@
15111511 }
15121512 $PGfilter = "(&(objectSid=$PGsid_string)(objectclass=$objectclass))";
15131513 $this->printDebug( "Primary Group Filter: $PGfilter", SENSITIVE );
1514 - $info = @ldap_search( $ldapconn, $base, $PGfilter );
1515 - $PGentries = @ldap_get_entries( $ldapconn, $info );
 1514+ $info = @ldap_search( $this->ldapconn, $base, $PGfilter );
 1515+ $PGentries = @ldap_get_entries( $this->ldapconn, $info );
15161516 array_shift( $PGentries );
15171517 $dnMember = strtolower( $PGentry[0]['dn'] );
15181518 $groups["dn"][] = $dnMember;

Status & tagging log